SetTextJustification() fix

[Keith Dunwoody]

Hi,

A little while ago I sent a fix for bug #50 (PrgWin95: Text justification needs
beefing up), in which SetTextJustification() wasn't spacing text lines out
properly.  I was wondering why my patch was rejected.

Thanks,

-- Keith

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

[Mike McCormack]

Keith Dunwoody wrote:
> A little while ago I sent a fix for bug #50 (PrgWin95: Text justification needs
> beefing up), in which SetTextJustification() wasn't spacing text lines out
> properly.  I was wondering why my patch was rejected.

Hi Keith,

I searched wine-patches for a mail with your name on it, but couldn't 
find one in the last few months.  Could you post your patch to 
wine-patches again, or provide a link to it so we can review it?

You might also check over the bullet points at:

http://www.winehq.org/site/sending_patches

Joseph Black has also been collecting a list of comments that various 
developers have made about patches:

http://wiki.jswindle.com/index.php/Coding_Hints

Mike

[Keith Dunwoody]

Hi,

My patch is here: http://www.winehq.org/hypermail/wine-patches/2005/06/0035.html

--- Mike McCormack  wrote:
> Keith Dunwoody wrote:
> > A little while ago I sent a fix for bug #50 (PrgWin95: Text justification
>
> needs
> > beefing up), in which SetTextJustification() wasn't spacing text lines out
> > properly.  I was wondering why my patch was rejected.
>
> Hi Keith,
>
> I searched wine-patches for a mail with your name on it, but couldn't 
> find one in the last few months.  Could you post your patch to 
> wine-patches again, or provide a link to it so we can review it?
>
> You might also check over the bullet points at:
>
> http://www.winehq.org/site/sending_patches
>
> Joseph Black has also been collecting a list of comments that various 
> developers have made about patches:
>
> http://wiki.jswindle.com/index.php/Coding_Hints
>
> Mike

__________________________________ 
Discover Yahoo! 
Get on-the-go sports scores, stock quotes, news and more. Check it out! 
http://discover.yahoo.com/mobile.html

[Mike McCormack]

Keith Dunwoody wrote:
> My patch is here: http://www.winehq.org/hypermail/wine-patches/2005/06/0035.html

I can't see anything immediately wrong with it.  It's not immediately 
obvious that it's right though... I guess Julliard is not sure about it, 
so has placed it in the "makes me think too much" basket.

The only thing I can think you could do to speed things up would be to 
post a graphical test application (hopefully one you wrote yourself), 
and screenshots for it on Windows and Wine to wine-patches so somebody 
else can test it if there's further problems.

Other than that, you can wait for Alexandre's comment...

Mike