Re: [6/6] oleaut32/tests: Add a bunch of new tests for typelib generation.

[Alexandre Julliard]

Dmitry Timoshkov  writes:
> Signed-off-by: Dmitry Timoshkov
>
> dlls/oleaut32/tests/test_tlb.idl |  59 +++++++++
>  dlls/oleaut32/tests/typelib.c    | 259 ++++++++++++++++++++++++++++++++++++---
>  2 files changed, 298 insertions(+), 20 deletions(-)

This is causing build warnings. I understand it may be deliberate in
order to test that path, but a standard build should be warning-free so
this needs to be done differently.

../../../tools/widl/widl -o test_tlb.tlb -m32 -I. -I../../../include -D__WINESRC__ test_tlb.idl
warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753903}
warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753906}
warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396b}
warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396d}
warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753970}
warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753972}

[6/6] oleaut32/tests: Add a bunch of new tests for typelib generation.

[Dmitry Timoshkov]

Alexandre Julliard  wrote:
> This is causing build warnings. I understand it may be deliberate in
> order to test that path, but a standard build should be warning-free so
> this needs to be done differently.
>
> ../../../tools/widl/widl -o test_tlb.tlb -m32 -I. -I../../../include -D__WINESRC__ test_tlb.idl
> warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753903}
> warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753906}
> warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396b}
> warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396d}
> warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753970}
> warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753972}

Frankly, I don't know how to avoid warnings for the things that intentionally
test things that cause these warnings. Do you have a suggestion how to avoid
warnings? Perhaps a widl flag to silence the warnings, and use it when building
the test_tlb.idl?

[6/6] oleaut32/tests: Add a bunch of new tests for typelib generation.

[Alexandre Julliard]

Dmitry Timoshkov  writes:
> Alexandre Julliard  wrote:
> > This is causing build warnings. I understand it may be deliberate in
> > order to test that path, but a standard build should be warning-free so
> > this needs to be done differently.
> >
> > ../../../tools/widl/widl -o test_tlb.tlb -m32 -I. -I../../../include -D__WINESRC__ test_tlb.idl
> > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753903}
> > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753906}
> > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396b}
> > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396d}
> > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753970}
> > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753972}
>
> Frankly, I don't know how to avoid warnings for the things that intentionally
> test things that cause these warnings. Do you have a suggestion how to avoid
> warnings? Perhaps a widl flag to silence the warnings, and use it when building
> the test_tlb.idl?

The right way would probably be to implement midl_pragma warning(disable).

[6/6] oleaut32/tests: Add a bunch of new tests for typelib generation.

[Alexandre Julliard]

Alexandre Julliard  writes:
> Dmitry Timoshkov  writes:
> > Alexandre Julliard  wrote:
> > > This is causing build warnings. I understand it may be deliberate in
> > > order to test that path, but a standard build should be warning-free so
> > > this needs to be done differently.
> > >
> > > ../../../tools/widl/widl -o test_tlb.tlb -m32 -I. -I../../../include -D__WINESRC__ test_tlb.idl
> > > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753903}
> > > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753906}
> > > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396b}
> > > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a75396d}
> > > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753970}
> > > warning: duplicate uuid {016fe2ec-b2c8-45f8-b23b-39e53a753972}
> >
> > Frankly, I don't know how to avoid warnings for the things that intentionally
> > test things that cause these warnings. Do you have a suggestion how to avoid
> > warnings? Perhaps a widl flag to silence the warnings, and use it when building
> > the test_tlb.idl?
>
> The right way would probably be to implement midl_pragma warning(disable).

I put the patch in and silenced the warning for now. We can re-enable it
once there's a way to avoid it in the test.