As asked to me, I have separated the dib engine into a patchset, trying to keep (when possible) the original author's submissions, so Huw Davies, Jesse Allen and me. I had to change some of other author's commits in order to fit my engine and to rebase it on 1.1.14, so I ask both previous authors to check if they agree on the patches.
I hope this will help the review, as keeping it rebased on wine tree will become quite hard having it as a separated patchset.
Attached here is a zipped patchset, which apply on wine 1.1.14.
Ciao
Max
On Sun, Feb 1, 2009 at 9:29 AM, Massimo Del Fedele max@veneto.com wrote:
As asked to me, I have separated the dib engine into a patchset, trying to keep (when possible) the original author's submissions, so Huw Davies, Jesse Allen and me. I had to change some of other author's commits in order to fit my engine and to rebase it on 1.1.14, so I ask both previous authors to check if they agree on the patches.
I hope this will help the review, as keeping it rebased on wine tree will become quite hard having it as a separated patchset.
Attached here is a zipped patchset, which apply on wine 1.1.14.
Ciao
Max
Hello,
I have placed the patches unchanged onto this git page: http://repo.or.cz/w/wine/dibdrv-max.git
Hope this helps.
Jesse
Jesse Allen ha scritto:
On Sun, Feb 1, 2009 at 9:29 AM, Massimo Del Fedele max@veneto.com wrote:
As asked to me, I have separated the dib engine into a patchset, trying to keep (when possible) the original author's submissions, so Huw Davies, Jesse Allen and me. I had to change some of other author's commits in order to fit my engine and to rebase it on 1.1.14, so I ask both previous authors to check if they agree on the patches.
I hope this will help the review, as keeping it rebased on wine tree will become quite hard having it as a separated patchset.
Attached here is a zipped patchset, which apply on wine 1.1.14.
Ciao
Max
Hello,
I have placed the patches unchanged onto this git page: http://repo.or.cz/w/wine/dibdrv-max.git
Hope this helps.
Jesse
Hi Jesse,
I've been out for job for a while, but I don't see many comments about the patch..... I guess I'll stop developing the engine for now. It makes few sense to code for something that will probably never be accepted.....
Ciao
Max
On 2009-02-06 (Friday) 12:40:51 Massimo Del Fedele wrote:
I've been out for job for a while, but I don't see many comments about the patch..... I guess I'll stop developing the engine for now. It makes few sense to code for something that will probably never be accepted.....
Did you try to talk about your implementation of DIB engine with Alexandre (on IRC or e-mail privately)? If not you should try. BTW, if you get almost zero comments this isn't necessary bad thing - this usually means that nobody has anything bad to say about your implementation and this is good thing. However, if Alexandre see something wrong in your implementation you need to talk to him personally about this to understand what's wrong and how you can improve it. Personally I think you are doing important and useful job because many programs can benefit from DIB engine including AutoCAD.
2009/2/6 L. Rahyen research@science.su:
On 2009-02-06 (Friday) 12:40:51 Massimo Del Fedele wrote:
I've been out for job for a while, but I don't see many comments about the patch..... I guess I'll stop developing the engine for now. It makes few sense to code for something that will probably never be accepted.....
Did you try to talk about your implementation of DIB engine with Alexandre (onIRC or e-mail privately)? If not you should try. BTW, if you get almost zero comments this isn't necessary bad thing - this usually means that nobody has anything bad to say about your implementation and this is good thing. However, if Alexandre see something wrong in your implementation you need to talk to him personally about this to understand what's wrong and how you can improve it. Personally I think you are doing important and useful job because many programs can benefit from DIB engine including AutoCAD.
I agree, you should stop by #winehackers and chat to Alexandre. Perhaps Huw, and Jesse could also join in a discussion about the best way forward.
Luke.
-
Jesse Allen -
L. Rahyen -
Luke Benstead -
Massimo Del Fedele