Re: advapi32: Add more SID tests

[Alexandre Julliard]

Robert Reif  writes:
> Adds more SID tests.
> Fixes some Windows  failures by checking version first.

You shouldn't check the Windows version, you should check the features
themselves.

advapi32: Add more SID tests

[Robert Reif]

Alexandre Julliard wrote:
> Robert Reif  writes:
> > Adds more SID tests.
> > Fixes some Windows  failures by checking version first.
>
> You shouldn't check the Windows version, you should check the features
> themselves.

ConvertStringSidToSid is supported on NT and later but the particular 
type of two character sid that I am testing is only avaliable on XP and 
later.
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/secauthz/se...

advapi32: Add more SID tests

[Alexandre Julliard]

Robert Reif  writes:
> ConvertStringSidToSid is supported on NT and later but the particular
> type of two character sid that I am testing is only avaliable on XP
> and later.

Yes, but the right way is to call it and check if it works. On Wine
the Windows version can report anything but the function will still
work, and should be tested.