Re: [PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

[Alexandre Julliard]

Misha Koshelev  writes:
> dlls/msi/automation.c        |   36 +++++++++++++++++++-
>  dlls/msi/msiserver.idl       |    4 ++
>  dlls/msi/msiserver_dispids.h |    1 +
>  dlls/msi/tests/automation.c  |   74 ++++++++++++++++++++----------------------

This one fails make test for me:

../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok
automation.c:1944: Test failed: Installer_ProductInfo failed, hresult 0x00000000
make[2]: *** [automation.ok] Error 1

[PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

[Misha Koshelev]

On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote:
> Misha Koshelev  writes:
> > dlls/msi/automation.c        |   36 +++++++++++++++++++-
> >  dlls/msi/msiserver.idl       |    4 ++
> >  dlls/msi/msiserver_dispids.h |    1 +
> >  dlls/msi/tests/automation.c  |   74 ++++++++++++++++++++----------------------
>
> This one fails make test for me:
>
> ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok
> automation.c:1944: Test failed: Installer_ProductInfo failed, hresult 0x00000000
> make[2]: *** [automation.ok] Error 1

Hmm... works for me but let me try doing a make clean; make depend; make
on all of wine to make sure something somewhere else has not changed
that changed its behavior.

Misha

[PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

[Michael Stefaniuc]

Misha Koshelev wrote:
> On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote:
> > Misha Koshelev  writes:
> > > dlls/msi/automation.c        |   36 +++++++++++++++++++-
> > >  dlls/msi/msiserver.idl       |    4 ++
> > >  dlls/msi/msiserver_dispids.h |    1 +
> > >  dlls/msi/tests/automation.c  |   74 ++++++++++++++++++++----------------------
> >
> > This one fails make test for me:
> >
> > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok
> > automation.c:1944: Test failed: Installer_ProductInfo failed, hresult 0x00000000
> > make[2]: *** [automation.ok] Error 1
>
> Hmm... works for me but let me try doing a make clean; make depend; make
> on all of wine to make sure something somewhere else has not changed
> that changed its behavior.

Sometimes you even need to remove your .wine directory too. Not that the 
tests assume something is already present in the enviroment.

bye
    michael

[PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

[Misha Koshelev]

On Wed, 2007-05-16 at 17:23 +0200, Michael Stefaniuc wrote:
> Misha Koshelev wrote:
> > On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote:
> > > Misha Koshelev  writes:
> > > > dlls/msi/automation.c        |   36 +++++++++++++++++++-
> > > >  dlls/msi/msiserver.idl       |    4 ++
> > > >  dlls/msi/msiserver_dispids.h |    1 +
> > > >  dlls/msi/tests/automation.c  |   74 ++++++++++++++++++++----------------------
> > >
> > > This one fails make test for me:
> > >
> > > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok
> > > automation.c:1944: Test failed: Installer_ProductInfo failed, hresult 0x00000000
> > > make[2]: *** [automation.ok] Error 1
> >
> > Hmm... works for me but let me try doing a make clean; make depend; make
> > on all of wine to make sure something somewhere else has not changed
> > that changed its behavior.
>
> Sometimes you even need to remove your .wine directory too. Not that the 
> tests assume something is already present in the enviroment.
>
> bye
>    michael

Alright, I am afraid I am stumped here. I simply cannot reproduce
Alexandre's error. I have done a ./configure --prefix=/usr; make clean;
make depend; make; sudo make install and removed my ~/.wine and
everything still works hunky dory with the patch (and of course I did a
git fetch; git rebase origin first).

If anyone else could try applying it to their git tree, doing a make and
sudo make install in dlls/msi, wineprefixcreate (because IDL defns have
to be updated in the fake DLLs in the ~/.wine directory), and then make
automation.ok in the dlls/msi/tests directory and let me know if it
works for them that would be great.

I've attached the patch to the current git head below. It is the same as
the one on the wine-devel list except I've set my emacs to use spaces
now instead of tabs (and diff -w shows no differences except the
headers).

Thanks
Misha

[PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

[Misha Koshelev]

On Wed, 2007-05-16 at 17:23 +0200, Michael Stefaniuc wrote:
> Misha Koshelev wrote:
> > On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote:
> > > Misha Koshelev  writes:
> > > > dlls/msi/automation.c        |   36 +++++++++++++++++++-
> > > >  dlls/msi/msiserver.idl       |    4 ++
> > > >  dlls/msi/msiserver_dispids.h |    1 +
> > > >  dlls/msi/tests/automation.c  |   74 ++++++++++++++++++++----------------------
> > >
> > > This one fails make test for me:
> > >
> > > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok
> > > automation.c:1944: Test failed: Installer_ProductInfo failed, hresult 0x00000000
> > > make[2]: *** [automation.ok] Error 1
> >
> > Hmm... works for me but let me try doing a make clean; make depend; make
> > on all of wine to make sure something somewhere else has not changed
> > that changed its behavior.
>
> Sometimes you even need to remove your .wine directory too. Not that the 
> tests assume something is already present in the enviroment.
>
> bye
>    michael

Alright, I think I know what's going on. I will submit some new patches.

Misha