Re: d3d10: Add annotation skipping.

[Henri Verbeet]

2009/8/15 Rico Schüller :
> +static inline void parse_annotation(const char **ptr, unsigned int count)
> +{
> - unsigned int i;
> - DWORD d[3];
> -
> - if(count == 0) return;
> -
> - FIXME("Skipping %#x annotation(s):\n", count);
> - for (i = 0; i < count; ++i)
> - {
> -
>    read_dword(ptr, &d[0]);
> -
>    read_dword(ptr, &d[1]);
> -
>    read_dword(ptr, &d[2]);
> -
>    FIXME("\t0x%08x 0x%08x 0x%08x\n", d[0], d[1], d[2]);
> - }
>
> +}

Please try to stick to the general structure of the other parsing
functions. I.e., something like this:

static void parse_fx10_annotation(const char **ptr)
{
    skip_dword_unknown(ptr, 3);
}

and

{
    unsigned int i;
...
    read_dword(ptr, &p->annotation_count);
    for (i = 0; i < p->annotation_count; ++i)
    {
        parse_fx10_annotation(ptr);
    }
...
}

d3d10: Add annotation skipping.

[David Laight]

On Sat, Aug 15, 2009 at 07:37:12PM +0200, Henri Verbeet wrote:
> 2009/8/15 Rico Sch?ller :
> > +static inline void parse_annotation(const char **ptr, unsigned int count)

^^^^^^

And there is no reason to inline something this size ....

David