For some reason, on fvwm2 sometimes focus_window will be restored and activated between the subsequent call to SetForegroundWindow() and the next call to ShowWindow(SW_RESTORE), causing the next test to fail. Flushing first seems to reliably work around this.
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- I don't know why this occurs. The messages sent suggest that a WM_STATE is received from fvwm2, and this triggers handle_wm_state_notify() to call SetActiveWindow() and send SC_RESTORE. But it's not clear why WM_STATE would be sent at that point. I can't reproduce the problem on my end more than once in a large number of times, so debugging is rather difficult.
dlls/d3d8/tests/device.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 819c1cd944..9fc06c3c9d 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -3151,6 +3151,7 @@ static void test_wndproc(void) ok(!expect_messages->message, "Expected message %#x for window %#x, but didn't receive it.\n", expect_messages->message, expect_messages->window); expect_messages = NULL; + flush_events(); SetForegroundWindow(GetDesktopWindow()); flush_events();
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=58921
Your paranoid android.
=== w1064v1809_ar (32 bit report) ===
d3d8: device.c:1672: Test failed: Reset failed, hr 0x88760873. device.c:1674: Test failed: TestCooperativeLevel failed, hr 0x88760869.
=== w1064v1809_zh_CN (32 bit report) ===
d3d8: device.c:3797: Test failed: Expected device window style 0x14cf0000, got 0x14000000. device.c:3801: Test failed: Expected device window extended style 0x108, got 0x8. device.c:3815: Test failed: Client rect and window rect are equal. device.c:6621: Test failed: Failed to update texture, hr 0x80004005, case 6. device.c:6621: Test failed: Failed to update texture, hr 0x80004005, case 7.