Re: Fix user/kernel times of GetProcessTimes()

[Mike McCormack]

Sidney Fong wrote:
> From 487243c1040f7ed17bd9241fc0f63f3f4774d76d Mon Sep 17 00:00:00 2001
> From: FONG Sidney Hok Nang 
> Date: Sun, 22 Oct 2006 15:36:38 +0800
> Subject: Fix user/kernel times of GetProcessTimes()
>
> Changes:
> Fix the known bug[1] of GetProcessTimes() where it originally returned
> the user/kernel times of the current process instead of the designated
> one

Hi,

Thanks for the patch!

Please attach it to your mail, or use git imap-send so it doesn't get 
line wrapped by Thunderbird, otherwise it won't apply properly:

mike@black:~/wine$ patch -p1 --dry-run < Fix\ user_kernel\ times\ of\ 
GetProcessTimes().eml
patching file dlls/kernel32/time.c
patch: **** malformed patch at line 96: @@ -533,27 +530,6 @@ VOID WINAPI 
GetSystemTimeAsFileTime(
> dlls/kernel32/time.c           |   30 ++--------------------------
> dlls/ntdll/process.c           |    2 ++
> include/wine/server_protocol.h |    2 ++
> server/process.c               |   29 +++++++++++++++++++++++++++
> server/process.h               |    5 +++++
> server/ptrace.c                |   43
> +++++++++++++++++++++++++++++++++++++---
> 6 files changed, 80 insertions(+), 31 deletions(-)

To change the server protocol, change server/protocol.def, then run 
tools/make_requests.  When you submit your patch, there's no need to 
include changes to include/wine/server_protocol.h or server/trace.c, so 
commit the changes to those files separately.
> - /*** The following chunk is taken from suspend_for_ptrace() ***/

For this code, rather than copying, it would be nicer to integrate your 
code with the existing suspect_for_ptrace() function.

Mike