RE: Handling dialog messages for non-template based dialogs

[Santosh Siddheshwar]

Could you take a look at this fix? I would think I have resolved the other
issue with SetDefButton as well. Tests with msg ran fine.
Regards
Santosh Siddheshwar
 <<patch.diff>>
> -----Original Message-----
> From:	Dmitry Timoshkov [SMTP:[e-mail]]
> Sent:	Friday, April 16, 2004 1:35 PM
> To:	Santosh Siddheshwar; Alexandre Julliard
> Cc:	Robert Shearman; [e-mail]
> Subject:	Re: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar"  wrote:
> > This test fails with WINE even after I create the DIALOGINFO structure
>
> the
> > first time it enters DefDlgProc. Not sure why this test should work on
> > Windows.
>
> Since I wrote it under Windows it apparently works there.
> > Basically at the stage where you are setting DM_SETDEFID there are
> > no child windows on the dialog.
>
> Yes, I was also confused when I saw this for the first time.
> > Then what does DM_SETDEFID and DM_GETDEFID do when there are no child
> > controls on the dialog?
>
> Looks like it should store id in the dialog structure, and only then try
> to change the look of a control.
> > My guess is implementation of DEFDLG_SetDefButton
> > may need to change.
>
> Yes, but that's another bug, not related to your patch. Although it would
> be
> great if you could fix that as well, don't bother if you have no time,
> I'll
> fix it later, this should be a very simple patch.
>
> -- 
> Dmitry.

*********************************************************************
Disclaimer: The information in this e-mail and any attachments is
confidential / privileged. It is intended solely for the addressee or
addressees. If you are not the addressee indicated in this message, you may
not copy or deliver this message to anyone. In such case, you should destroy
this message and kindly notify the sender by reply email. Please advise
immediately if you or your employer does not consent to Internet email for
messages of this kind.
*********************************************************************

Handling dialog messages for non-template based dialogs

[Dmitry Timoshkov]

"Santosh Siddheshwar"  wrote:
> Could you take a look at this fix? I would think I have resolved the other
> issue with SetDefButton as well. Tests with msg ran fine.

The only thing that I'd suggest to remove is a misleading comment
about WM_NCCREATE, otherwise the patch looks good.