Re: [PATCH 2/3] msvcp90/tests: Added allocator<char> tests

[Alexandre Julliard]

Piotr Caban  writes:
> diff --git a/dlls/msvcp90/tests/Makefile.in b/dlls/msvcp90/tests/Makefile.in
> index b7fb8e5..9ac5ef5 100644
> --- a/dlls/msvcp90/tests/Makefile.in
> +++ b/dlls/msvcp90/tests/Makefile.in
> @@ -5,7 +5,7 @@ VPATH     = @srcdir@
>  TESTDLL   = msvcp90.dll
>  APPMODE   = -mno-cygwin
>  MODCFLAGS = @BUILTINFLAG@
> -EXTRAINCL = -I$(TOPSRCDIR)/include/msvcrt
> +EXTRAINCL = -I$(TOPSRCDIR)/include/msvcrt -I$(SRCDIR)/..

Don't do that. Define the macros you need directly in the test file.

[PATCH 2/3] msvcp90/tests: Added allocator<char> tests

[Piotr Caban]

On 07/22/10 17:04, Alexandre Julliard wrote:
> Piotr Caban  writes:
> > diff --git a/dlls/msvcp90/tests/Makefile.in b/dlls/msvcp90/tests/Makefile.in
> > index b7fb8e5..9ac5ef5 100644
> > --- a/dlls/msvcp90/tests/Makefile.in
> > +++ b/dlls/msvcp90/tests/Makefile.in
> > @@ -5,7 +5,7 @@ VPATH     = @srcdir@
> >   TESTDLL   = msvcp90.dll
> >   APPMODE   = -mno-cygwin
> >   MODCFLAGS = @BUILTINFLAG@
> > -EXTRAINCL = -I$(TOPSRCDIR)/include/msvcrt
> > +EXTRAINCL = -I$(TOPSRCDIR)/include/msvcrt -I$(SRCDIR)/..
>
> Don't do that. Define the macros you need directly in the test file.

Almost all tests will need macros for calling functions. Should I define 
them in every test file?

[PATCH 2/3] msvcp90/tests: Added allocator<char> tests

[Alexandre Julliard]

Piotr Caban  writes:
> Almost all tests will need macros for calling functions. Should I
> define them in every test file?

You can have a header in the tests if absolutely necessary.