[PATCH] wine.inf: Enable Light theme by default.

[Zhiyi Zhang]

Signed-off-by: Zhiyi Zhang 
---
 loader/wine.inf.in | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/loader/wine.inf.in b/loader/wine.inf.in
index 0e488d87dcb..3e6194a3929 100644
--- a/loader/wine.inf.in
+++ b/loader/wine.inf.in
@@ -71,6 +71,7 @@ AddReg=\
     Services, \
     SessionMgr,\
     Tapi,\
+    ThemeManager,\
     Timezones,\
     LicenseInformation

@@ -95,6 +96,7 @@ AddReg=\
     Services, \
     SessionMgr,\
     Tapi,\
+    ThemeManager,\
     Timezones,\
     VersionInfo,\
     LicenseInformation
@@ -121,6 +123,7 @@ AddReg=\
     Services, \
     SessionMgr,\
     Tapi,\
+    ThemeManager,\
     Timezones,\
     VersionInfo.ntamd64,\
     LicenseInformation
@@ -147,6 +150,7 @@ AddReg=\
     Services, \
     SessionMgr,\
     Tapi,\
+    ThemeManager,\
     Timezones,\
     VersionInfo.ntamd64,\
     LicenseInformation
@@ -5494,6 +5498,12 @@ ServiceType=32
 StartType=3
 ErrorControl=1

+[ThemeManager]
+HKCU,"Software\Microsoft\Windows\CurrentVersion\ThemeManager","ThemeActive",2,"1"
+HKCU,"Software\Microsoft\Windows\CurrentVersion\ThemeManager","DllName",2,"%10%\resources\themes\light\light.msstyles"
+HKCU,"Software\Microsoft\Windows\CurrentVersion\ThemeManager","ColorName",2,"Blue"
+HKCU,"Software\Microsoft\Windows\CurrentVersion\ThemeManager","SizeName",2,"NormalSize"
+
 [WinmgmtService]
 Description="Provides access to Windows Management Instrumentation"
 DisplayName="Windows Management Instrumentation Service"

[Esme Povirk (she/they)]

I don't know if this is important, but Wine Mono has a few tests of
exact sizes that break with this theme.

For example:
x86_64.MonoTests.System.Windows.Forms.ToolStripTests:Constructor failed:
  A12
  Expected: {X=7,Y=0,Width=92,Height=25}
  But was:  {X=9,Y=0,Width=90,Height=25}

Corresponding source code:
https://github.com/madewokherd/mono/blob/56d140974e5fa56d83d29c41e933ff11cd3...

I haven't been able to figure out how exactly the theme affects this
calculation. It's possible there's a bug in Wine's uxtheme, Mono, or
winforms code that only gets called when visual styles are enabled.

If this is determined by the theme and Windows has been keeping it
constant, that's probably for a reason, but I don't have an easy way
to test with XP, Vista, and 7 themes.

[Zhiyi Zhang]

On 3/15/22 02:35, Esme Povirk (she/they) wrote:
> I don't know if this is important, but Wine Mono has a few tests of
> exact sizes that break with this theme.
>
> For example:
> x86_64.MonoTests.System.Windows.Forms.ToolStripTests:Constructor failed:
>   A12
>   Expected: {X=7,Y=0,Width=92,Height=25}
>   But was:  {X=9,Y=0,Width=90,Height=25}
>
> Corresponding source code:
> https://github.com/madewokherd/mono/blob/56d140974e5fa56d83d29c41e933ff11cd3...
>
> I haven't been able to figure out how exactly the theme affects this
> calculation. It's possible there's a bug in Wine's uxtheme, Mono, or
> winforms code that only gets called when visual styles are enabled.
>
> If this is determined by the theme and Windows has been keeping it
> constant, that's probably for a reason, but I don't have an easy way
> to test with XP, Vista, and 7 themes.

I can take a look. Thanks for spotting this.

Thanks,
Zhiyi

[Fabian Maurer]

Hello,

the following Application is broken by the new theme:
https://bugs.winehq.org/show_bug.cgi?id=52667

Would you mind taking a look?

Regards,
Fabian Maurer

[Zhiyi Zhang]

Hi Fabian,

Thanks for reporting this. I will take a look when I have time.

Best Regards,
Zhiyi

On 3/18/22 10:26, Fabian Maurer wrote:
> Hello,
>
> the following Application is broken by the new theme:
> https://bugs.winehq.org/show_bug.cgi?id=52667
>
> Would you mind taking a look?
>
> Regards,
> Fabian Maurer