Re: RegDeleteTree [3rd]

[Robert Shearman]

Stefan Leichter wrote:
> Am Thursday 19 April 2007 12:14 schrieb Alexandre Julliard:
> > Stefan Leichter  writes:
> > > - } else {
> > > -
> > >        if (!ret)
> > > -
> > >        ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0);
> >
> > The function is supposed to delete the key values, that's not what
> > this does.
> >
> > You probably need to write some test cases...
>
> Hello Alexandre,
>
> i 'm not sure what you mean with this point. I have now added a loop to delete 
> all value/data pairs, but this loop is only executed for the default entry 
> (value NULL).
>
> If the implementation is not fine for you, can you please suggest detailed 
> test cases to be proved.

Perhaps:
s/RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 
0)/RegDeleteValueW(hSubKey, NULL)/

RegDeleteTree [3rd]

[Stefan Leichter]

Am Wednesday 25 April 2007 23:00 schrieb Robert Shearman:
> Stefan Leichter wrote:
> > Am Thursday 19 April 2007 12:14 schrieb Alexandre Julliard:
> > > Stefan Leichter  writes:
> > > > - } else {
> > > > -
> > > >        if (!ret)
> > > > -
> > > >        ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0);
> > >
> > > The function is supposed to delete the key values, that's not what
> > > this does.
> > >
> > > You probably need to write some test cases...
> >
> > Hello Alexandre,
> >
> > i 'm not sure what you mean with this point. I have now added a loop to
> > delete all value/data pairs, but this loop is only executed for the
> > default entry (value NULL).
> >
> > If the implementation is not fine for you, can you please suggest
> > detailed test cases to be proved.
>
> Perhaps:
> s/RegSetValueW(hSubKey, NULL, REG_SZ, emptyW,
> 0)/RegDeleteValueW(hSubKey, NULL)/

I don't expect to get an empty string back when reading the data of the 
default value in this case.

Correct me if i'm wrong.
--
Stefan