Re: [1/3] apphelp: Add definitions

[Dmitry Timoshkov]

Mislav Blazevic  wrote:
> dlls/apphelp/apphelp.c |  10 +-
>  dlls/apphelp/apphelp.h | 272 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 273 insertions(+), 9 deletions(-)
>  create mode 100644 dlls/apphelp/apphelp.h

Where all of this comes from? Is there an application that calls
apphelp APIs and doesn't work because of failures? How are you
testing your implementation?

[1/3] apphelp: Add definitions

[Mislav Blazevic]

It mostly comes from feeding SdbTagToString all valid inputs. Some
constants are from msdn. I do not know of a *real* program calling this API
other than winapi itself. kernel32 uses it for backwards compatibility. I
wrote plenty of tests[1], parsed shim database files
(C:\windows\AppPatch*.sdb) and matched an entry in datatabse with
executable[2] (Yes, I know [2] is done wrong but that's my dirty working
branch)

[1] https://github.com/krofna/wine/blob/master/dlls/apphelp/tests/apphelp.c
[2] https://github.com/krofna/wine/blob/master/dlls/kernel32/process.c#L1088

On Fri, Aug 16, 2013 at 4:07 AM, Dmitry Timoshkov  wrote:
> Mislav Blazevic  wrote:
> > dlls/apphelp/apphelp.c |  10 +-
> >  dlls/apphelp/apphelp.h | 272
>
> +++++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 273 insertions(+), 9 deletions(-)
> >  create mode 100644 dlls/apphelp/apphelp.h
>
> Where all of this comes from? Is there an application that calls
> apphelp APIs and doesn't work because of failures? How are you
> testing your implementation?
>
> --
> Dmitry.

[1/3] apphelp: Add definitions

[Dmitry Timoshkov]

[please bottom post when replying]

Mislav Blazevic  wrote:
> It mostly comes from feeding SdbTagToString all valid inputs. Some
> constants are from msdn. I do not know of a *real* program calling this API
> other than winapi itself. kernel32 uses it for backwards compatibility. I
> wrote plenty of tests[1], parsed shim database files
> (C:\windows\AppPatch*.sdb) and matched an entry in datatabse with
> executable[2] (Yes, I know [2] is done wrong but that's my dirty working
> branch)
>
> [1] https://github.com/krofna/wine/blob/master/dlls/apphelp/tests/apphelp.c
> [2] https://github.com/krofna/wine/blob/master/dlls/kernel32/process.c#L1088

How is this supposed to be used in Wine?

[1/3] apphelp: Add definitions

[Mislav Blazevic]

Same way its used in windows, obviously... Does wine somehow explicitly
forbids applying binary patches on loaded executables? Can you please tell
me which feature of apphelp won't work on wine?

On Fri, Aug 16, 2013 at 12:20 PM, Dmitry Timoshkov  wrote:
> [please bottom post when replying]
>
> Mislav Blazevic  wrote:
> > It mostly comes from feeding SdbTagToString all valid inputs. Some
> > constants are from msdn. I do not know of a *real* program calling this
>
> API
> > other than winapi itself. kernel32 uses it for backwards compatibility. I
> > wrote plenty of tests[1], parsed shim database files
> > (C:\windows\AppPatch*.sdb) and matched an entry in datatabse with
> > executable[2] (Yes, I know [2] is done wrong but that's my dirty working
> > branch)
> >
> > [1]
>
> https://github.com/krofna/wine/blob/master/dlls/apphelp/tests/apphelp.c
> > [2]
>
> https://github.com/krofna/wine/blob/master/dlls/kernel32/process.c#L1088
>
> How is this supposed to be used in Wine?
>
> --
> Dmitry.

[1/3] apphelp: Add definitions

[Dmitry Timoshkov]

Mislav Blazevic  wrote:
> Same way its used in windows, obviously... Does wine somehow explicitly
> forbids applying binary patches on loaded executables? Can you please tell
> me which feature of apphelp won't work on wine?

You didn't actually answer the question and for some reason ignored
> > [please bottom post when replying]

[1/3] apphelp: Add definitions

[Mislav Blazevic]

Pardon my ignorance... What does it mean to bottom post? I am new to
mailing lists.

I thought you asked that because you knew why it won't work. I don't know
how it will work until I do it. If there is reason why it cannot work,
*please* tell me before I write any more code.

On Fri, Aug 16, 2013 at 12:44 PM, Dmitry Timoshkov  wrote:
> Mislav Blazevic  wrote:
> > Same way its used in windows, obviously... Does wine somehow explicitly
> > forbids applying binary patches on loaded executables? Can you please
>
> tell
> > me which feature of apphelp won't work on wine?
>
> You didn't actually answer the question and for some reason ignored
> > > [please bottom post when replying]
>
> --
> Dmitry.

[1/3] apphelp: Add definitions

[GOUJON Alexandre]

On 08/16/2013 12:50 PM, Mislav Blazevic wrote:
> Pardon my ignorance... What does it mean to bottom post? I am new to 
> mailing lists.

GIYF : http://en.wikipedia.org/wiki/Posting_style#Bottom-posting