Re: Minor dlls/comctl32/tests/listview.c simplification

[Nikolay Sivov]

On 4/21/2010 21:32, Gerald Pfeifer wrote:
> ChangeLog:
> Remove variable hwndheader which is not really used from test_items.
>
> diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c
> index 2c5ef70..06f2ddd 100644
> --- a/dlls/comctl32/tests/listview.c
> +++ b/dlls/comctl32/tests/listview.c
> @@ -1182,7 +1182,7 @@ static void test_items(void)
>
> static void test_columns(void)
>   {
> - HWND hwnd, hwndheader;
> - HWND hwnd;
>  LVCOLUMN column;
>  DWORD rc;
>  INT order[2];
>
> @@ -1207,7 +1207,6 @@ static void test_columns(void)
>   /* LVM_GETCOLUMNORDERARRAY */
>   hwnd = create_listview_control(LVS_REPORT);
> -
>
> hwndheader = subclass_header(hwnd);
>
> memset(&column, 0, sizeof(column));
>  column.mask = LVCF_WIDTH;

Hi, Gerald.

You can't do this, subclassing is important thing here. And you will see 
it if you run a test (that you should do before sending patch actually).

Minor dlls/comctl32/tests/listview.c simplification

[Gerald Pfeifer]

On Thu, 22 Apr 2010, Nikolay Sivov wrote:
> You can't do this, subclassing is important thing here. And you will see 
> it if you run a test (that you should do before sending patch actually).

Thanks, Nikolay.  You're perfectly right, that was a silly mistake of
mine, no way to put this differently.  I've had problems running the
tests on my machine I primarily use for Wine work, but now managed to
address this (which involved patching mmap.c, but seems to work now).

Gerald