Re: KERNEL32: Improve descriptions

[Alexandre Julliard]

Vitaly Lipatov  writes:
> -UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix, UINT unique, LPWSTR buffer )
> +UINT WINAPI GetTempFileNameW( LPCWSTR lpPathName, LPCWSTR lpPrefixString, UINT uUnique, LPWSTR lpTempFileName )

*Please* don't change nice readable parameter names into the horrible
Hungarian line noise format.

KERNEL32: Improve descriptions

[Vitaly Lipatov]

On Sunday 05 March 2006 14:13, Alexandre Julliard wrote:
> Vitaly Lipatov  writes:
> > -UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix,
> > UINT unique, LPWSTR buffer ) +UINT WINAPI GetTempFileNameW(
> > LPCWSTR lpPathName, LPCWSTR lpPrefixString, UINT uUnique,
> > LPWSTR lpTempFileName )
>
> *Please* don't change nice readable parameter names into the
> horrible Hungarian line noise format.

Sorry, I thought we need to fix parameter names according to 
MSDN :(
Have we some policy about it? Will I change Hungarian notation to 
readable names when possible?

KERNEL32: Improve descriptions

[Marcus Meissner]

On Sun, Mar 05, 2006 at 07:39:04PM +0300, Vitaly Lipatov wrote:
> On Sunday 05 March 2006 14:13, Alexandre Julliard wrote:
> > Vitaly Lipatov  writes:
> > > -UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix,
> > > UINT unique, LPWSTR buffer ) +UINT WINAPI GetTempFileNameW(
> > > LPCWSTR lpPathName, LPCWSTR lpPrefixString, UINT uUnique,
> > > LPWSTR lpTempFileName )
> >
> > *Please* don't change nice readable parameter names into the
> > horrible Hungarian line noise format.
>
> Sorry, I thought we need to fix parameter names according to 
> MSDN :(
> Have we some policy about it? Will I change Hungarian notation to 
> readable names when possible?

Just don't change the name.

The *types* should be the same as MSDN, the *names* do not need to.

Ciao, Marcus

KERNEL32: Improve descriptions

[Kuba Ober]

> > > -UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix,
> > > UINT unique, LPWSTR buffer ) +UINT WINAPI GetTempFileNameW(
> > > LPCWSTR lpPathName, LPCWSTR lpPrefixString, UINT uUnique,
> > > LPWSTR lpTempFileName )
> >
> > *Please* don't change nice readable parameter names into the
> > horrible Hungarian line noise format.
>
> Sorry, I thought we need to fix parameter names according to
> MSDN :(

Weren't the parameter names an implementation detail that's essentially 
invisible to the api user (docs nothwithstanding)? I.e. there's no such thing 
as 'fixing them' according to MSDN, because the api spec itself has no 
authority over parameter names. Heck, they can be different (or nonexistent) 
in the header files than in implementation files, and so on, right?

Presumably the names should be nice so that wine maintainers can maintain the 
implementation ;)

Cheers, Kuba