Mike McCormack mike@codeweavers.com writes:
ChangeLog:
- define RPC_NO_WINDOWS_H to prevent rpc.h from including windows.h
Why do you need this?
Alexandre Julliard wrote:
- define RPC_NO_WINDOWS_H to prevent rpc.h from including windows.h
Why do you need this?
Well, that's the way that the Windows SDK version and the MingW version of rpc.h work... does it cause a problem?
Mike
Mike McCormack mike@codeweavers.com writes:
Alexandre Julliard wrote:
- define RPC_NO_WINDOWS_H to prevent rpc.h from including windows.h
Why do you need this?
Well, that's the way that the Windows SDK version and the MingW version of rpc.h work... does it cause a problem?
Well, it causes us to have to add -DRPC_NO_WINDOWS_H all over the place, which is exactly what the __WINESRC__ ifdef was supposed to avoid. Is there a reason to remove it? (other than the fact that Windows doesn't have it of course).
Alexandre Julliard wrote:
Well, it causes us to have to add -DRPC_NO_WINDOWS_H all over the place, which is exactly what the __WINESRC__ ifdef was supposed to avoid. Is there a reason to remove it? (other than the fact that Windows doesn't have it of course).
Well, admittedly the code works as is. Cross-compiling our code with MingW or MSVC may require it, but I guess it requires lots of other changes to the Makfiles too. Feel free to leave it for later.
Mike
Mike McCormack mike@codeweavers.com writes:
Well, admittedly the code works as is. Cross-compiling our code with MingW or MSVC may require it, but I guess it requires lots of other changes to the Makfiles too. Feel free to leave it for later.
It really shouldn't be required for cross-compiling either. The only reason we have that ifdef is because we have one in windows.h too, to discourage its use inside Wine. So building with other headers should work just fine since windows.h won't have the __WINESRC__ check, and building other code with our headers should work too since __WINESRC__ won't be defined then.
-
Alexandre Julliard -
Mike McCormack