Re: [4/4] kernel32: Add localized version resource.

[Alexandre Julliard]

Akihiro Sagawa  writes:
> diff --git a/dlls/kernel32/version.rc b/dlls/kernel32/version.rc
> index 411bd6e..dbaee67 100644
> --- a/dlls/kernel32/version.rc
> +++ b/dlls/kernel32/version.rc
> @@ -16,6 +16,13 @@
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>
> */
>
> +#include "winresrc.h"
> -
>
> +#pragma makedep po
> -
>
> +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
> -
>
> +#define WINE_FILEDESCRIPTION_STR "#msgctxt#kernel32#Wine Core DLL"
>  #define WINE_FILENAME_STR "kernel32.dll"

Is there a reason that this needs to be kernel32 specific? Why couldn't
other dlls use the translation too?

[4/4] kernel32: Add localized version resource.

[Akihiro Sagawa]

On Wed, 15 Mar 2017 09:49:30 +0100, Alexandre Julliard wrote:
> Akihiro Sagawa  writes:
> > diff --git a/dlls/kernel32/version.rc b/dlls/kernel32/version.rc
> > index 411bd6e..dbaee67 100644
> > --- a/dlls/kernel32/version.rc
> > +++ b/dlls/kernel32/version.rc
> > @@ -16,6 +16,13 @@
> > - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> >
> > */
> >
> > +#include "winresrc.h"
> > -
> >
> > +#pragma makedep po
> > -
> >
> > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
> > -
> >
> > +#define WINE_FILEDESCRIPTION_STR "#msgctxt#kernel32#Wine Core DLL"
> >  #define WINE_FILENAME_STR "kernel32.dll"
>
> Is there a reason that this needs to be kernel32 specific? Why couldn't
> other dlls use the translation too?

Thanks for your comments. From my point of view, only translation for
kernel32 is needed because that is cause of Bug 41757. How about using
specific text for kernel32, like "Wine kernel DLL", and keeping
untranslated for other DLLs?

I think native applications rarely verify system DLL's language in
version resource as seen in Bug 41757. Moreover, in the native, not all
dlls have translated version resource. For instance (see below):
 [Have translation]
 - ntdll.dll
 - d3d8.dll (in Windows XP)
 [No translations]
 - version.dll
 - d3d8.dll (in Windows 7)
 - d3d9.dll

"Wine Core DLL" is widely used among DLLs and slightly ambiguous. IMHO,
if we use common translation text, they will waste disk space and don't
help users.

Akihiro Sagawa

[4/4] kernel32: Add localized version resource.

[Alexandre Julliard]

Akihiro Sagawa  writes:
> On Wed, 15 Mar 2017 09:49:30 +0100, Alexandre Julliard wrote:
> > Akihiro Sagawa  writes:
> > > diff --git a/dlls/kernel32/version.rc b/dlls/kernel32/version.rc
> > > index 411bd6e..dbaee67 100644
> > > --- a/dlls/kernel32/version.rc
> > > +++ b/dlls/kernel32/version.rc
> > > @@ -16,6 +16,13 @@
> > > - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> > >
> > > */
> > >
> > > +#include "winresrc.h"
> > > -
> > >
> > > +#pragma makedep po
> > > -
> > >
> > > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
> > > -
> > >
> > > +#define WINE_FILEDESCRIPTION_STR "#msgctxt#kernel32#Wine Core DLL"
> > >  #define WINE_FILENAME_STR "kernel32.dll"
> >
> > Is there a reason that this needs to be kernel32 specific? Why couldn't
> > other dlls use the translation too?
>
> Thanks for your comments. From my point of view, only translation for
> kernel32 is needed because that is cause of Bug 41757. How about using
> specific text for kernel32, like "Wine kernel DLL", and keeping
> untranslated for other DLLs?

Yes, a more descriptive name unique to kernel32 would be better. I don't
think we should be abusing message contexts for that sort of thing.