Re: FD_ZERO and FD_SET problems.

[Michael Stefaniuc]

Could you please resubmit it as unified diff (diff -u)? The diff's are
more readable and are more robust regarding to changes in the target
file.

bye
    michael

On Fri, Sep 20, 2002 at 08:10:41PM -1000, Patrick J. McNerthney wrote:
> I hope I am doing this correctly.  I am porting some Win32 software
> using WineLib and ran into some problems with the WinSock headers,
> specifically with regards to the use of FD_ZERO and FD_SET (they just
> wouldn't compile at all).  Attached is the patch that resolved my
> problems.
>
> ChangeLog
>   Fixed if statement in __WS_FD_SET2 which did not have it's outer set
> of parenthesis.
>   Removed parentheses around type to be cast in __WS_FD_SET macro.
>   Removed WS macro usage from within other macros because the WS macro
> is undefined when these macros are expanded.
>
> Pat McNerthney
> Icicle Software, Inc.

FD_ZERO and FD_SET problems.

[Patrick J. McNerthney]

> Could you please resubmit it as unified diff (diff -u)? The diff's are
> more readable and are more robust regarding to changes in the target
> file.
>
> bye
> michael

Sorry about that, I missed the step on the WineHQ website with regards
to ensuring the .cvsrc has been properly set up.

In the meantime, I have identified a couple of other problems, so I have
included those as well.

ChangeLog for winsock.h
  Removed the $undef of WS_DEFINE_SELECT so that select is in fact
defined.
  Fixed if statement in __WS_FD_SET2 which used a = where a == is
needed, in additition the if did not have it's outer set of parenthesis.
  Removed parentheses around type to be cast in __WS_FD_SET macro.
  Removed WS macro usage from within other macros because the WS macro
is undefined when these macros are expanded.
  Added WINAPI attribe to select defintion.

ChangeLog for crtdbg.h
  Added casts to all macros to avoid compiler warnings.

Pat McNerthney
Icicle Software, Inc.