Re: [PATCH 1/2] vbscript: Implemented Date(try 2)

[Nikolay Sivov]

On 8/23/2014 19:38, Shuai Meng wrote:
> - GetLocalTime(&lt);
> - ud.st = lt;
> - VarDateFromUdateEx(&ud, 0, VAR_DATEVALUEONLY, &date);
> - return return_date(res, date);

It's better to init 'wDayOfYear' part too, even if it's not used 
internally +variant will show its garbage value. Also I'm not sure about 
ignoring return value of VarDateFromUdateEx().

[PATCH 1/2] vbscript: Implemented Date(try 2)

[Shuai Meng]

Thank you for commenting~

2014-08-23 23:45 GMT+08:00 Nikolay Sivov :
> On 8/23/2014 19:38, Shuai Meng wrote:
> > - GetLocalTime(&lt);
> > - ud.st = lt;
> > - VarDateFromUdateEx(&ud, 0, VAR_DATEVALUEONLY, &date);
> > - return return_date(res, date);
>
> It's better to init 'wDayOfYear' part too, even if it's not used
> internally +variant will show its garbage value.

I will check this.
> Also I'm not sure about ignoring return value of VarDateFromUdateEx().
>
> I am not sure as well , but maybe it's better to add it.