On 21.11.2015 20:16, Michael Gilbert wrote:
On Sat, Nov 21, 2015 at 11:47 AM, Svante Signell wrote:
Signed-off by: svante.signell@gmail.com
Hello,
Submitting this patch directly to wine-patches on request from Jens Ryer.
BTW: There are still some parts of the code using PATH_MAX, but does not seem to be triggered with the debian builds. Is it of interest to remove also the remaining entries?
The PATH_MAX in libs/wine/loader.c is in an #ifdef __sun block, so it's not very relevant. There are two other instances which would probably be nice to fix.
winepulse.drv makes perfect sense, since this buffer is used with Win32 API, and pa_proplist_sets() dynamically allocates property value, so it could be of any length.
The rest:
- loader.c is fine I think; - mountmgr.sys/diskarb.c and dbghelp/macho_module.c are macos-only, so maybe it's okay too if PATH_MAX defined specifically for macos. Ken, could you please comment?
Best wishes, Mike
On Nov 22, 2015, at 4:55 AM, Nikolay Sivov bunglehead@gmail.com wrote:
- mountmgr.sys/diskarb.c and dbghelp/macho_module.c are macos-only,
so maybe it's okay too if PATH_MAX defined specifically for macos. Ken, could you please comment?
I'm not completely clear on what the problem being addressed is. Those two uses are, indeed, in Mac-only code so I don't think there's any cross-platform compatibility issue. If the concern is the size, it should be adequate for most purposes. It's defined to be 1024 in <sys/limits.h>. Certainly, it's larger than MAX_PATH (260).
Regards, Ken
On 22.11.2015 16:24, Ken Thomases wrote:
On Nov 22, 2015, at 4:55 AM, Nikolay Sivov bunglehead@gmail.com wrote:
- mountmgr.sys/diskarb.c and dbghelp/macho_module.c are macos-only, so maybe it's okay too if PATH_MAX defined specifically for macos. Ken, could you please comment?
I'm not completely clear on what the problem being addressed is. Those two uses are, indeed, in Mac-only code so I don't think there's any cross-platform compatibility issue. If the concern is the size, it should be adequate for most purposes. It's defined to be 1024 in <sys/limits.h>. Certainly, it's larger than MAX_PATH (260).
My understanding is that's an attempt to fix dependency on system-specific define, when we don't have to depend on it, like in submitted winepulse.drv patch.
Regards, Ken
-
Ken Thomases -
Nikolay Sivov