Re: x11drv: One more fix for "stuck" ctrl, shift & alt.

[Vitaliy Margolen]

Anything wrong with this patch? It does fix the "stuck alt" problem for
games I use alt+tab on.

Vitaliy Margolen

Tuesday, February 21, 2006, 10:30:39 PM, Vitaliy Margolen wrote:
> ChangeLog:
> x11drv: One more fix for "stuck" ctrl, shift & alt.
> DInput needs scan code with each event - make sure we send one.
> Also don't loose key state change events in mouse.c
> I tested this with Keyboard DInput sample from DXSDK. It clearly showed
> that we are loosing these events when focus is being changed.
> dlls/x11drv/keyboard.c |   10 +++++-----
>  dlls/x11drv/mouse.c    |    6 ++++--
>  dlls/x11drv/x11drv.h   |    2 ++
>  3 files changed, 11 insertions(+), 7 deletions(-)

x11drv: One more fix for "stuck" ctrl, shift & alt.

[Tomas Carnecky]

Vitaliy Margolen wrote:
> Anything wrong with this patch? It does fix the "stuck alt" problem for
> games I use alt+tab on.

I can confirm that this fixes the bug. This patch is very important for
me as I don't have to switch back and forth between desktop and WoW to
un-stuck they alt-key. This patch works fine and I don't see any
side-effects.

tom

x11drv: One more fix for "stuck" ctrl, shift & alt.

[Kuba Ober]

On Saturday 11 March 2006 14:03, Tomas Carnecky wrote:
> Vitaliy Margolen wrote:
> > Anything wrong with this patch? It does fix the "stuck alt" problem for
> > games I use alt+tab on.
>
> I can confirm that this fixes the bug. This patch is very important for
> me as I don't have to switch back and forth between desktop and WoW to
> un-stuck they alt-key. This patch works fine and I don't see any
> side-effects.

This problem affects non-game applications as well. Happens all the time with 
Zilog Developer Studio II, an IDE for embedded application development.
So, here's my vote for this patch :)

Cheers, Kuba Ober