Re: [PATCH 4/5] ddraw/tests: Port the depth blit test to ddraw2

[Henri Verbeet]

On 22 January 2012 16:32, Stefan Dösinger  wrote:
> - /* FIXME: This is wrong, d3d2 does not have D3DRENDERSTATE_LIGHTING. D3DLVERTEX should
> - * disable lighting. This needs more tests and fixes after Wine 1.4 */
> - hr = IDirect3DDevice2_SetRenderState(device, D3DRENDERSTATE_LIGHTING, FALSE);

It probably makes sense to just skip this call and add a todo_wine for
the failing tests. Also, if all that's needed for this is setting
WINED3D_RS_LIGHTING in IDirect3DDeviceImpl_2_DrawPrimitive(), I think
that should be ok to go in before 1.4.

[PATCH 4/5] ddraw/tests: Port the depth blit test to ddraw2

[Stefan Dösinger]

Am Montag, 23. Januar 2012, 13:48:03 schrieb Henri Verbeet:
> It probably makes sense to just skip this call and add a todo_wine for
> the failing tests. Also, if all that's needed for this is setting
> WINED3D_RS_LIGHTING in IDirect3DDeviceImpl_2_DrawPrimitive(), I think
> that should be ok to go in before 1.4.

I've sent the patch with todo_wine for now. A proper fix might be as simple as 
a SetRenderState call in the device2::draw* thunks, but I don't feel 
comfortable about it without some tests. I'm not sure if I'll have the time 
for that.

Someone(Octavian? I lost the IRC logs) was working on a lot of tests for this. 
Maybe he wants to resume his work.