Move patches from wine-staging to mainline

[Kai Krakow]

Hello!

Since a similar discussion has come up, what would be the proposed way to
suggest tested patches from staging to mainline?

I'm currently carrying one or another selected (simple) patch from staging
in my local patch-set that I apply to the latest wine version tag (so, I'm
not running master). And these patches have proven quality for me since a
view versions now.

Should I just submit the patch to this list and remove Signed-off-by?
Should I add Tested-by? Should I contact the original author first?

Or should I add something to the subject like "PATCH suggest", and let "git
send-mail" also ping the original author?

Regards,
Kai

[Alistair Leslie-Hughes]

Hi Kai,

On 15/03/18 18:46, Kai Krakow wrote:
Hello!

Since a similar discussion has come up, what would be the proposed way to suggest tested patches from staging to mainline?

I'm currently carrying one or another selected (simple) patch from staging in my local patch-set that I apply to the latest wine version tag (so, I'm not running master). And these patches have proven quality for me since a view versions now.
That good that other are testing the patches.  The main point here is to make sure they will be acceptable upstream.
For example many of the wined3d/d3dx patches, work really well but need more work before they will be accepted.

Which patches are looking at?

Should I just submit the patch to this list and remove Signed-off-by? Should I add Tested-by? Should I contact the original author first?

Or should I add something to the subject like "PATCH suggest", and let "git send-mail" also ping the original author?
Leave the "Signed-off-by" there unless you have made major changes to the logic of the original patch.  Your
"Signed-off-by" needs to be there as well.

Please use git send-mail.

Alistair.

[Kai Krakow]

Hi.

Alistair Leslie-Hughes  schrieb am Do., 15.
März 2018 um 10:02 Uhr:
> Hi Kai,
>
> On 15/03/18 18:46, Kai Krakow wrote:
>
> Hello!
>
> Since a similar discussion has come up, what would be the proposed way to
> suggest tested patches from staging to mainline?
>
> I'm currently carrying one or another selected (simple) patch from staging
> in my local patch-set that I apply to the latest wine version tag (so, I'm
> not running master). And these patches have proven quality for me since a
> view versions now.
>
> That good that other are testing the patches.  The main point here is to
> make sure they will be acceptable upstream.
> For example many of the wined3d/d3dx patches, work really well but need
> more work before they will be accepted.
>
> Which patches are looking at?

None special yet, it's more about how I'm going to handle this later.
Currently, there's maybe one patch that I would suggest for now after
another round of testing.
> Should I just submit the patch to this list and remove Signed-off-by?
> Should I add Tested-by? Should I contact the original author first?
>
> Or should I add something to the subject like "PATCH suggest", and let
> "git send-mail" also ping the original author?
>
> Leave the "Signed-off-by" there unless you have made major changes to the
> logic of the original patch.  Your
> "Signed-off-by" needs to be there as well.

I think depending on the complexity of the patch, I might contact the
author first as Andrew suggested. It sounds like a good thing to do.
> Please use git send-mail.

I already do.

Regards,
Kai

[Anton Romanov]

On Thu, Mar 15, 2018 at 11:49 AM, Kai Krakow  wrote:
> Hi.
>
> Alistair Leslie-Hughes  schrieb am Do., 15.
> März 2018 um 10:02 Uhr:
> > Hi Kai,
> >
> > On 15/03/18 18:46, Kai Krakow wrote:
> >
> > Hello!
> >
> > Since a similar discussion has come up, what would be the proposed way to
> > suggest tested patches from staging to mainline?
> >
> > I'm currently carrying one or another selected (simple) patch from staging
> > in my local patch-set that I apply to the latest wine version tag (so, I'm
> > not running master). And these patches have proven quality for me since a
> > view versions now.
> >
> > That good that other are testing the patches.  The main point here is to
> > make sure they will be acceptable upstream.

Yeah, keep in mind that while some patches work pretty well and are
written correctly from code point of view they won't be accepted due
to architectural concerns.
For example multimonitor pathcset while working perfectly and allowing
apps to run on multimonitor systems have been lingering in staging for
years because it goes against wine project leaders' vision of how
certain things should be architectured.

Aside from trying to reach to patch author it is also possible to
search wine-devel archives to see if it was ever sent upstream and if
yes then why was it not accepted before.

[Andrew Eikum]

On Thu, Mar 15, 2018 at 07:46:25AM +0000, Kai Krakow wrote:
> Should I contact the original author first?

Do consider contacting the original author. I think it's polite, and
ideally they will be willing to work to upstream it themselves. If
not, then they might offer you guidance as to what could be wrong with
the patch, or how to improve it to go upstream.

Andrew