powerpoint: images upside down - wine-devel - winehq.org

List overview All Threads

powerpoint: images upside down

Re: [ntdll] fix GetProcAddress on...

[msvcrt] how to handle msvcr*.dll ...

Cihan Altinay

28 Nov 2005 28 Nov '05

7:58 a.m.

Hi,

When using MS Powerpoint 2003 images are drawn upside down in fullscreen (presentation) mode but not in design mode. Also, text is drawn correctly as seen on the attachments.

I would appreciate a hint on what traces/logs to provide for more info as the dc & win output is quite long.

Thanks, Cihan

Attachments:

design_mode.jpg (image/jpeg — 7.2 KB)
presentation_mode.jpg (image/jpeg — 7.0 KB)

Show replies by date

Uwe Bonnes

28 Nov 28 Nov

9:09 a.m.

...
...
...
...
"Cihan" == Cihan Altinay cihan@uq.edu.au writes:

Cihan> Hi, When using MS Powerpoint 2003 images are drawn upside down in Cihan> fullscreen (presentation) mode but not in design mode. Also, Cihan> text is drawn correctly as seen on the attachments.

Cihan> I would appreciate a hint on what traces/logs to provide for more Cihan> info as the dc & win output is quite long.

Is the error reproducable with the downloadable powerpoint viewer?

Can you perhaps put a small powerpoint file online, showing that error?

This will make things easier for others to pick up. Also perhaps pit these files and description in the bugs database.

Bye

-- Uwe Bonnes bon@elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

Cihan Altinay

11:45 p.m.

Quoting Uwe Bonnes bon@elektron.ikp.physik.tu-darmstadt.de:

...
...
...
...
"Cihan" == Cihan Altinay cihan@uq.edu.au writes:

Cihan> Hi, When using MS Powerpoint 2003 images are drawn upside down in
Cihan> fullscreen (presentation) mode but not in design mode.  Also,
Cihan> text is drawn correctly as seen on the attachments.

Cihan> I would appreciate a hint on what traces/logs to provide for more
Cihan> info as the dc & win output is quite long.

Is the error reproducable with the downloadable powerpoint viewer?

Unfortunately, Powerpoint Viewer 2003 presents a black screen to me (see bug #3905 which is apparently fixed, but not for me...).

Can you perhaps put a small powerpoint file online, showing that error? This will make things easier for others to pick up. Also perhaps pit these files and description in the bugs database.

Thanks for the hints. Fortunately this gets fixed applying the patch Huw mentioned. Should I still open a bug report and mention the patch?

Cihan

Huw D M Davies

10 a.m.

On Mon, Nov 28, 2005 at 05:58:50PM +1000, Cihan Altinay wrote:

Hi,

When using MS Powerpoint 2003 images are drawn upside down in fullscreen (presentation) mode but not in design mode. Also, text is drawn correctly as seen on the attachments.

I would appreciate a hint on what traces/logs to provide for more info as the dc & win output is quite long.

It's because there's no implementation of SetBitmapBits for dib sections. Alexandre committed this patch to the CrossOver tree, I'm not sure why it didn't make it into WineHQ.

Huw.

-- Huw Davies huw@codeweavers.com Index: dlls/gdi/bitmap.c =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/gdi/bitmap.c,v retrieving revision 1.1.1.7.6.2 retrieving revision 1.1.1.7.6.3 diff -u -p -r1.1.1.7.6.2 -r1.1.1.7.6.3 --- dlls/gdi/bitmap.c 7 Oct 2005 16:42:05 -0000 1.1.1.7.6.2 +++ dlls/gdi/bitmap.c 24 Oct 2005 11:31:35 -0000 1.1.1.7.6.3 @@ -381,6 +381,31 @@ LONG WINAPI SetBitmapBits( count = -count; } + if (bmp->dib) /* simply copy the bits into the DIB */ + { + DIBSECTION *dib = bmp->dib; + char *dest = dib->dsBm.bmBits; + DWORD max = dib->dsBm.bmWidthBytes * dib->dsBm.bmHeight; + if (count > max) count = max; + ret = count; + + if (bmp->dib->dsBmih.biHeight >= 0) /* not top-down, need to flip contents vertically */ + { + dest += dib->dsBm.bmWidthBytes * dib->dsBm.bmHeight; + while (count > 0) + { + dest -= dib->dsBm.bmWidthBytes; + memcpy( dest, bits, min( count, dib->dsBm.bmWidthBytes ) ); + bits = (char *)bits + dib->dsBm.bmWidthBytes; + count -= dib->dsBm.bmWidthBytes; + } + } + else memcpy( dest, bits, count ); + + GDI_ReleaseObj( hbitmap ); + return ret; + } + /* Only get entire lines */ height = count / bmp->bitmap.bmWidthBytes; if (height > bmp->bitmap.bmHeight) height = bmp->bitmap.bmHeight;

Cihan Altinay

11:33 p.m.

Quoting Huw D M Davies h.davies1@physics.ox.ac.uk:

On Mon, Nov 28, 2005 at 05:58:50PM +1000, Cihan Altinay wrote:

...
Hi,

When using MS Powerpoint 2003 images are drawn upside down in fullscreen (presentation) mode but not in design mode. Also, text is drawn correctly as seen on the attachments.

I would appreciate a hint on what traces/logs to provide for more info as the dc & win output is quite long.

It's because there's no implementation of SetBitmapBits for dib sections. Alexandre committed this patch to the CrossOver tree, I'm not sure why it didn't make it into WineHQ.

Wow, with this patch everything displays perfectly, thanks! I, too, wonder why it isn't in wine yet?!

Huw.

Thanks again, Cihan

6964

Age (days ago)

6964

Last active (days ago)

wine-devel@winehq.org

4 comments

3 participants

tags (0)

participants (3)

Cihan Altinay
Huw D M Davies
Uwe Bonnes