Re: [PATCH 03/15] d3dx9: Use size of variable instead of type.

[Nikolay Sivov]

On 3/23/2011 13:49, Rico Schüller wrote:
> dlls/d3dx9_36/effect.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>       len = MultiByteToWideChar(CP_ACP, 0, srcfile, -1, NULL, 0);
> - srcfileW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR));
> - srcfileW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(*srcfileW));
>  MultiByteToWideChar(CP_ACP, 0, srcfile, -1, srcfileW, len);

No need to zero, if it will be filled with next call. This could a 
subject of next patch of course.

[PATCH 03/15] d3dx9: Use size of variable instead of type.

[Rico Schüller]

Am 23.03.2011 12:00, schrieb Nikolay Sivov:
> On 3/23/2011 13:49, Rico Schüller wrote:
> > dlls/d3dx9_36/effect.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >       len = MultiByteToWideChar(CP_ACP, 0, srcfile, -1, NULL, 0);
> > - srcfileW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len *
> >
> > sizeof(WCHAR));
> > - srcfileW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len *
> >
> > sizeof(*srcfileW));
> >       MultiByteToWideChar(CP_ACP, 0, srcfile, -1, srcfileW, len);
>
> No need to zero, if it will be filled with next call. This could a 
> subject of next patch of course.

Yeah, I'll send a patch for that one. Thanks for the hint.

Cheers
Rico