Re: [PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.

[Stefan Dösinger]

Am Wednesday 02 September 2009 09:27:58 schrieb Henri Verbeet:
> -
>    GL_EXTCALL(glGetProgramivARB(GL_FRAGMENT_PROGRAM_ARB,
>
> GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB, &native)); +       
> checkGLcall("glGetProgramivARB()");
> -
>    if (!native) WARN("Program exceeds native resource limits.\n");
> - }

shouldn't that be a FIXME? The most likely reasons for this are either that we 
advertise incorrect caps, or our privately added code breaks the limits, or 
that the driver is broken. In the first two cases we can do something, and in 
the other case we might want to report the issue to the driver devs

That said, I haven't seen a GL implementation yet that successfully compiles 
and SW-emulates a program that exceeds the limits.

[PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.

[Henri Verbeet]

2009/9/2 Stefan Dösinger :
> Am Wednesday 02 September 2009 09:27:58 schrieb Henri Verbeet:
> > - GL_EXTCALL(glGetProgramivARB(GL_FRAGMENT_PROGRAM_ARB,
> >
> > GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB, &native)); +
> > checkGLcall("glGetProgramivARB()");
> > - if (!native) WARN("Program exceeds native resource limits.\n");
> > - }
>
> shouldn't that be a FIXME? The most likely reasons for this are either that we
> advertise incorrect caps, or our privately added code breaks the limits, or
> that the driver is broken. In the first two cases we can do something, and in
> the other case we might want to report the issue to the driver devs
>
> That said, I haven't seen a GL implementation yet that successfully compiles
> and SW-emulates a program that exceeds the limits.

It isn't necessarily a problem when this happens, it's more meant as a
diagnostic while debugging.

[PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.

[Stefan Dösinger]

Am Wednesday 02 September 2009 15:07:42 schrieb Henri Verbeet:
> > That said, I haven't seen a GL implementation yet that successfully
> > compiles and SW-emulates a program that exceeds the limits.
>
> It isn't necessarily a problem when this happens, it's more meant as a
> diagnostic while debugging.

Well, its most likely going to bring performance down to unplayable levels, 
but using it just as diagnostics is fine with me