On Mon, Nov 21, 2016 at 12:38 PM, Jeremy Newman jnewman@winehq.org wrote:
... include/header.php | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/include/header.php b/include/header.php index 014a8c4..ff01e3b 100644 --- a/include/header.php +++ b/include/header.php @@ -2,28 +2,31 @@ /*********************************/ /* Application Database - Header */ /*********************************/ -?><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> -<html> +?><!doctype html> +<html lang="en">
<head> <title>WineHQ <?php echo $title; ?></title> - <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> - <meta HTTP-EQUIV="Expires" CONTENT="Mon, 06 Jan 1990 00:00:01 GMT"> - <meta HTTP-EQUIV="Pragma" CONTENT="no-cache"> + + <meta charset="utf-8"> <meta name="description" content="Open Source Software for running Windows applications on other operating systems."> <meta name="keywords" content="windows, linux, macintosh, solaris, freebsd"> <meta name="robots" content="index, follow"> <meta name="copyright" content="Copyright WineHQ.org All Rights Reserved."> <meta name="language" content="English"> <meta name="revisit-after" content="1"> + + <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1q8mTJOASx8j1Au+a5WDVnPi2lkFfwwEAa8hDDdjZlpLegxhjVME1fgjWPGmkzs7" crossorigin="anonymous"> + <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.6.1/css/font-awesome.min.css"> + <link rel="stylesheet" href="https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.css" type="text/css" media="all">
Why not https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.min.css ?
It is not required, so why add it? The only jquery-ui control we are using currently is dialog() for screenshots. If we start adding more jquery-ui controls, I'll add a theme. It will most likely be a custom theme-roller made one.
-N
November 21, 2016 3:01 PM, "Bruno Jesus" 00cpxxx@gmail.com wrote:
Why not https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.min.css ?
On Tue, Nov 22, 2016 at 12:52 PM, Jeremy Newman jnewman@codeweavers.com wrote:
It is not required, so why add it? The only jquery-ui control we are using currently is dialog() for screenshots. If we start adding more jquery-ui controls, I'll add a theme. It will most likely be a custom theme-roller made one.
I was not clear enough, sorry. You have added minified versions of the other files, but added the standard file for jquery-ui. Why not also use the minified version of jquery-ui?
Standard: https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.css Minified: https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.min.css
Best wishes, Bruno
Ha! You are correct. Not sure what I was thinking. Fixed!
-N
November 22, 2016 9:10 AM, "Bruno Jesus" 00cpxxx@gmail.com wrote:
On Tue, Nov 22, 2016 at 12:52 PM, Jeremy Newman jnewman@codeweavers.com wrote:
It is not required, so why add it? The only jquery-ui control we are using currently is dialog() for screenshots. If we start adding more jquery-ui controls, I'll add a theme. It will most likely be a custom theme-roller made one.
I was not clear enough, sorry. You have added minified versions of the other files, but added the standard file for jquery-ui. Why not also use the minified version of jquery-ui?
Standard: https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.css Minified: https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.min.css
-
Bruno Jesus -
Jeremy Newman