Re: [0/4] Improve wineconsole and kernel32

[Frédéric Delanoy]

On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster <
[e-mail]> wrote:
> This series of four patches will improve various three functions in
> kernel32:
> - GetConsoleFontSize
> - GetCurrentConsoleFont
> - GetLargestConsoleWindowSize
>
> This is achieved by moving logical calculations to wineconsole itself.
> kernel32.dll only receives the final values.
>
> The first and second patches should be applied to source before compiling
> Wine. If this is not done, the compiler will exit with errors. (The first
> is a patch for server/protocol.def and requires tools/make_requests to be
> run).

After each patch, Wine should be able to compile correctly (e.g. for
regression testing)
If not, you should split your patches differently IMO.

Frédéric

[0/4] Improve wineconsole and kernel32

[Hugh McMaster]

> > The first and second patches should be applied to source before compiling Wine. If this is not done, the compiler will exit with errors. (The first is a patch for server/protocol.def and requires tools/make_requests to be run).
> After each patch, Wine should be able to compile correctly (e.g. for regression testing)
> If not, you should split your patches differently IMO.
> Frédéric

Yes, I know. I thought that rule didn't apply when dealing with patches to server/protocol.def.

I'll combine the first and second patches together and resubmit.

Hugh