Re: [PATCH 3/3] oleacc: Add GetStateText implementation

[Nikolay Sivov]

> - ret = GetStateTextW(0, (WCHAR*)&ptr, 0);

Why not use id symbols, instead of magic numbers?

[PATCH 3/3] oleacc: Add GetStateText implementation

[Piotr Caban]

On 05/14/14 16:13, Nikolay Sivov wrote:
> > - ret = GetStateTextW(0, (WCHAR*)&ptr, 0);
>
> Why not use id symbols, instead of magic numbers?

It's quite common to use 0 as no-flag (it doesn't change anything now 
but STATE_SYSTEM_NORMAL is not defined when winuser.h is included). The 
tests are not really checking any specific flags, they are checking all 
possible values.