Re: [resend]: [dlls/dbgeng]: add initial stub dll implementation

[Paul Vriens]

On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote:
> (I am re-sending this patch as gmail did extra formattings to previous
> patches)

Hi,

+MODULE    = dbgeng.dll
+IMPORTLIB = dbgebg

Typo?

You also have to use your own wording for the comments, if needed at 
all, to the functions. You can't just copy-paste from MSDN.

[resend]: [dlls/dbgeng]: add initial stub dll implementation

[Volodymyr Shcherbyna]

Ouch, I did not know that. OK, I will re-format comments sections and typo
and will re-send patch again.

Thanks for pointing out.

2010/11/19 Paul Vriens
> On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote:
> > (I am re-sending this patch as gmail did extra formattings to previous
> > patches)
>
> Hi,
>
> +MODULE    = dbgeng.dll
> +IMPORTLIB = dbgebg
>
> Typo?
>
> You also have to use your own wording for the comments, if needed at all,
> to the functions. You can't just copy-paste from MSDN.
>
> --
> Cheers,
>
> Paul.

[resend]: [dlls/dbgeng]: add initial stub dll implementation

[Owen Rudge]

On 19/11/2010 16:04, Volodymyr Shcherbyna wrote:
> Ouch, I did not know that. OK, I will re-format comments sections and
> typo and will re-send patch again.

A minor niggle, but you should use your own name in the copyright line, 
rather than "WINE Project", as the project is not a legal entity in its 
own right.

[resend]: [dlls/dbgeng]: add initial stub dll implementation

[Volodymyr Shcherbyna]

I was not sure if I should put my name into (c) section just for such
a minor contribution, so I put WINE project.

2010/11/21 Owen Rudge :
> On 19/11/2010 16:04, Volodymyr Shcherbyna wrote:
> > Ouch, I did not know that. OK, I will re-format comments sections and
> > typo and will re-send patch again.
>
> A minor niggle, but you should use your own name in the copyright line,
> rather than "WINE Project", as the project is not a legal entity in its own
> right.
>
> --
> Owen Rudge
> http://www.owenrudge.net/

[resend]: [dlls/dbgeng]: add initial stub dll implementation

[James McKenzie]

On 11/21/10 4:26 AM, Volodymyr Shcherbyna wrote:
> 2010/11/21 Owen Rudge:
> > On 19/11/2010 16:04, Volodymyr Shcherbyna wrote:
> > > Ouch, I did not know that. OK, I will re-format comments sections and
> > > typo and will re-send patch again.
> >
> > A minor niggle, but you should use your own name in the copyright line,
> > rather than "WINE Project", as the project is not a legal entity in its own
> > right.
> >
> > --
> > Owen Rudge
> > http://www.owenrudge.net/
>
> I was not sure if I should put my name into (c) section just for such
> a minor contribution, so I put WINE project.

It's your code.  If you don't want to retain copyright to them, put 
nothing in the file.  Otherwise a copyright line for your code should be 
there.

Please resubmit with a copyright line for yourself, if you have not done so.

James McKenzie
>

[resend]: [dlls/dbgeng]: add initial stub dll implementation

[Volodymyr Shcherbyna]

2010/11/21 James McKenzie :

[...]
> It's your code.  If you don't want to retain copyright to them, put nothing
> in the file.  Otherwise a copyright line for your code should be there.
>
> Please resubmit with a copyright line for yourself, if you have not done so.
>
> James McKenzie

Thanks for the hint. Patch is edited and re-submitted (marked as attempt #5).