excessive stack space usage in NTDLL

[Marcus Meissner]

Hi,

The stackspace usage in dlls/ntdll/directory.c is affecting
programs. One installer crashes because of it I suspect.

objdump -d directory.o|grep "sub.*[0-9a-f][0-9a-f][0-9a-f],%esp"

wine_nt_to_unix_file_name	- 0x5f0	(1520 byte)
    	(in this my sample program crashes)
    append_entry			- 0x2cc (716 byte)
    NtQueryDirectoryFile		- 0x22d4 (8916 byte!)

problematic also cdrom.o
    DVD_ReadKey 			- 0x84c
    CDROM_DeviceIoControl 		- 0x40c

thread.o
    start_thread			- 0x830

nt.o
    NtQuerySystemInformation	- 0x990

How best to reduce? Allocate space with RtlAllocateHeap()?

Ciao, Marcus

[Alexandre Julliard]

Marcus Meissner  writes:
> The stackspace usage in dlls/ntdll/directory.c is affecting
> programs. One installer crashes because of it I suspect.

Is it by any chance because it does a recursive search of the disk and
runs out of stack?  If that's the case you'll most likely see the
overflow happen in one of the directory.c functions, but they are not
the real culprit since they are not themselves recursive.