Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45672 Signed-off-by: Jimi Huotari chiitoo@gentoo.org --- programs/winecfg/theme.c | 2 +- programs/winemenubuilder/winemenubuilder.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/programs/winecfg/theme.c b/programs/winecfg/theme.c index 66d23448f6..c47c9ed566 100644 --- a/programs/winecfg/theme.c +++ b/programs/winecfg/theme.c @@ -1165,7 +1165,7 @@ static void on_select_font(HWND hDlg)
static void init_mime_types(HWND hDlg) { - char *buf = get_reg_key(config_key, keypath("FileOpenAssociations"), "Enable", "Y"); + char *buf = get_reg_key(config_key, keypath("FileOpenAssociations"), "Enable", "N"); int state = IS_OPTION_TRUE(*buf) ? BST_CHECKED : BST_UNCHECKED;
CheckDlgButton(hDlg, IDC_ENABLE_FILE_ASSOCIATIONS, state); diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index fa700f8c19..88e1a3e7f2 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -3624,7 +3624,7 @@ static BOOL init_xdg(void)
static BOOL associations_enabled(void) { - BOOL ret = TRUE; + BOOL ret = FALSE; HKEY hkey; BYTE buf[32]; DWORD len;
On 24.06.19 01:11, Jimi Huotari wrote:
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45672 Signed-off-by: Jimi Huotari chiitoo@gentoo.org
This appears to not only disable the autogenerated file associations (i.e. the ones for builtin programs) like the bug report described, but prevents wine from adding file associations for manually installed programs as well.
Is that an intended effect of this patch?
While overriding file associations when starting wine for the first time isn't necessarily optimal (and it can definitely be annoying), not adding associations for user-installed programs is even worse in terms of user experience imho.
Tim
On Mon, 24 Jun 2019 03:23:27 +0200 Tim Schumacher timschumi@gmx.de wrote:
On 24.06.19 01:11, Jimi Huotari wrote:
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45672 Signed-off-by: Jimi Huotari chiitoo@gentoo.org
This appears to not only disable the autogenerated file associations (i.e. the ones for builtin programs) like the bug report described, but prevents wine from adding file associations for manually installed programs as well.
Is that an intended effect of this patch?
I'm not sure that I actually considered that, as I personally tend to disable the winemenubuilder completely. That is, I don't want anything to be added for manually installed things either.
The intent is to flip the default state of the particular setting.
While overriding file associations when starting wine for the first time isn't necessarily optimal (and it can definitely be annoying), not adding associations for user-installed programs is even worse in terms of user experience imho.
Tim
In my case it is an improvement. :]
Of course we're all different, and I would not be surprised if the majority differs, and if this ends up being a bit too much for a default.
Thank you for your feedback!
Jimi Huotari chiitoo@gentoo.org writes:
On Mon, 24 Jun 2019 03:23:27 +0200 Tim Schumacher timschumi@gmx.de wrote:
While overriding file associations when starting wine for the first time isn't necessarily optimal (and it can definitely be annoying), not adding associations for user-installed programs is even worse in terms of user experience imho.
Tim
In my case it is an improvement. :]
Of course we're all different, and I would not be surprised if the majority differs, and if this ends up being a bit too much for a default.
Yes, it seems too much. It should be possible to add a mechanism to avoid adding the associations that aren't useful, without disabling everything.
-
Alexandre Julliard -
Jimi Huotari -
Tim Schumacher