SHFormatDateTimeA() crashes when given a NULL input pointer which is not really useful to know.
Signed-off-by: Francois Gouget fgouget@codeweavers.com --- v3: Remove the test instead of documenting it. See: https://www.winehq.org/pipermail/wine-devel/2021-September/194251.html --- dlls/shlwapi/tests/ordinal.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c index bf43d35b1c2..0284800e10f 100644 --- a/dlls/shlwapi/tests/ordinal.c +++ b/dlls/shlwapi/tests/ordinal.c @@ -1674,12 +1674,6 @@ static void test_SHFormatDateTimeA(void) DWORD flags; INT ret;
-if (0) -{ - /* crashes on native */ - pSHFormatDateTimeA(NULL, NULL, NULL, 0); -} - GetLocalTime(&st); SystemTimeToFileTime(&st, &filetime); /* SHFormatDateTime expects input as utc */
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=97015
Your paranoid android.
=== debiant2 (32 bit Hindi:India report) ===
shlwapi: ordinal.c:1721: Test failed: expected ( ), got (05:17) ordinal.c:1728: Test failed: expected ( ), got (05:17:11) ordinal.c:1736: Test failed: expected ( ), got (05:17:11) ordinal.c:1743: Test failed: expected ( ), got (01-09-2021) ordinal.c:1750: Test failed: expected ( ), got (01 ??????? 2021) ordinal.c:1758: Test failed: expected ( ), got (01 ??????? 2021) ordinal.c:1766: Test failed: expected (F), got (7) for time part ordinal.c:1780: Test failed: expected (F), got (1) for time part ordinal.c:1798: Test failed: expected ( F), got (01-09-2021 05:17) ordinal.c:1809: Test failed: expected ( F F), got (01-09-2021 05:17:11)
-
Francois Gouget -
Marvin