Re: [PATCH v2 2/5] dxgi: Add feature level support.

[Henri Verbeet]

On 8 March 2016 at 23:19, Matteo Bruni  wrote:
> @@ -214,7 +215,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_CheckInterfaceSupport(IDXGIAdapter
>          return DXGI_ERROR_UNSUPPORTED;
>      }
> - if (FAILED(hr = dxgi_check_d3d10_support(adapter->parent, adapter)))
> - if (FAILED(hr = dxgi_check_feature_level_support(adapter->parent, adapter, &feature_level, 1)))
>     return DXGI_ERROR_UNSUPPORTED;

I don't think this does what you want it to do,
> -HRESULT dxgi_check_d3d10_support(struct dxgi_factory *factory, struct dxgi_adapter *adapter)
> +HRESULT dxgi_check_feature_level_support(struct dxgi_factory *factory, struct dxgi_adapter *adapter,
> -
>    const D3D_FEATURE_LEVEL *feature_levels, unsigned int level_count)

...
> - D3D_FEATURE_LEVEL selected_feature_level = 0;

...
> - return selected_feature_level;

because this doesn't match the return type.