Re: [1/2] gdiplus: Implement GdipGetVisibleClipBounds

[Henri Verbeet]

2009/8/12 Andrew Eikum :
> - GpStatus stat = Ok;

The initialization is redundant, since you always initialize stat
before using it.
> - if((stat = GdipCreateRegionRect(&wnd_rectf, &wnd_rgn) != Ok))
> -
>    return stat;

I don't think that does what you want it to do.

[1/2] gdiplus: Implement GdipGetVisibleClipBounds

[Andrew Eikum]

Henri Verbeet wrote:
> 2009/8/12 Andrew Eikum :
> > - GpStatus stat = Ok;
>
> The initialization is redundant, since you always initialize stat
> before using it.
> > - if((stat = GdipCreateRegionRect(&wnd_rectf, &wnd_rgn) != Ok))
> > -
> >    return stat;
>
> I don't think that does what you want it to do.

Thanks for the reply. Does this sit better with you?

[1/2] gdiplus: Implement GdipGetVisibleClipBounds

[Vincent Povirk]

> - /* get window bounds */
> - if(!GetClientRect(graphics->hwnd, &wnd_rect))
> -
>    return GenericError;

What if the Graphics object doesn't have a window?