"Steven Edwards" winehacker@gmail.com wrote:
Make on mingw does not like mixed line endings. Don't do it, ever. diffed from a cvs checkout as MSYS git is slower than molasses flowing uphill on a Minnesota winter day.
Changelog: open makedep in binary mode when writing or appending, move the EOF marker
I guess that you just use the sources fetched in Linux? Don't do that, get the source via cvs under Windows instead, in that case you don't get mixed line endings. Or alternatively convert LF to CRLF before building.
On Jan 20, 2008 12:43 AM, Dmitry Timoshkov dmitry@codeweavers.com wrote:
I guess that you just use the sources fetched in Linux? Don't do that, get the source via cvs under Windows instead, in that case you don't get mixed line endings. Or alternatively convert LF to CRLF before building.
MSYS cvs does not set Windows style line endings.
"Steven Edwards" winehacker@gmail.com wrote:
MSYS cvs does not set Windows style line endings.
Then this is a bug in MSYS CVS. My cvs.exe in Windows produces correct Wine sources, with cr/lf EOLs.
On Jan 20, 2008 9:45 PM, Dmitry Timoshkov dmitry@codeweavers.com wrote:
Then this is a bug in MSYS CVS. My cvs.exe in Windows produces correct Wine sources, with cr/lf EOLs.
It also happens with MSYS git and git is the preferred method of getting Winehq sources and there is no other GIT for windows so I say it should still be applied...unless you think I should perster the MSYS people to change the default line ending behavior for all applications in their runtime...
"Steven Edwards" winehacker@gmail.com wrote:
On Jan 20, 2008 9:45 PM, Dmitry Timoshkov dmitry@codeweavers.com wrote:
Then this is a bug in MSYS CVS. My cvs.exe in Windows produces correct Wine sources, with cr/lf EOLs.
It also happens with MSYS git and git is the preferred method of getting Winehq sources and there is no other GIT for windows so I say it should still be applied...unless you think I should perster the MSYS people to change the default line ending behavior for all applications in their runtime...
Fixing the bugs in MSYS would be preferrable IMO.
On Jan 20, 2008 10:24 PM, Dmitry Timoshkov dmitry@codeweavers.com wrote:
Fixing the bugs in MSYS would be preferrable IMO.
I forgot that Cygwin setup has the ability at the end of the install to set the default line endings, I assume msys being a derivative might have this capability but not enabled or its something that would be easy to rip from their sources. Maybe its an environmental variable or something. If Julliard rejects the patch then I'll look in to it.
-
Dmitry Timoshkov -
Steven Edwards