On Friday 31 October 2008 12:45:58 Dan Kegel wrote:
The public internet can (and does) go pear-shaped in the middle of test runs, which means any test that tries to access the public internet is de facto flaky, even if it tries to protect itself by skipping if the internet is down.
So let's provide a way for automated testers to force all hostname resolution requests to return the same result (say, 'localhost' or 'mytestserver'). Only include this in debugging builds.
What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code.
You would need to duplicate this code in every dll that does networking, if possible. I don't think it will work for wldap32, where there is no lookup call to hook into.
-Hans
On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker hans@codeweavers.com wrote:
What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code.
But the disadvantage that we need to know which servers the test code is going to look up. I guess I should change my patch to log the actual name being looked up, then we can get a list. Do we have any sort of policy about which hostnames can be used during tests?
You would need to duplicate this code in every dll that does networking, if possible. I don't think it will work for wldap32, where there is no lookup call to hook into.
That's ok, I'd happily duplicate it. - Dan
On Friday 31 October 2008 13:39:36 Dan Kegel wrote:
On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker hans@codeweavers.com wrote:
What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code.
But the disadvantage that we need to know which servers the test code is going to look up. I guess I should change my patch to log the actual name being looked up, then we can get a list. Do we have any sort of policy about which hostnames can be used during tests?
Yes, I think this could use a bit of standardization. Perhaps we could have a scheme like this:
http.test.winehq.org ftp.test.winehq.org ldap.test.winehq.org pop3.test.winehq.org ...
And mandate that networked tests use those. Then you would have a predictable list of hostnames to redirect.
-Hans
On Fri, Oct 31, 2008 at 6:15 AM, Hans Leidekker hans@codeweavers.com wrote:
Yes, I think this could use a bit of standardization. Perhaps we could have a scheme like this:
http.test.winehq.org ftp.test.winehq.org ldap.test.winehq.org pop3.test.winehq.org ...
And mandate that networked tests use those. Then you would have a predictable list of hostnames to redirect.
That sounds like a great idea regardless of what else we do. - Dan
-
Dan Kegel -
Hans Leidekker