Re: [PATCH] configure: Check if version of msgfmt/gettext is recent enough (at least 0.15).

[Alexandre Julliard]

Christian Costa  writes:
> @@ -284,6 +284,25 @@ AC_CHECK_PROGS(CONVERT, convert, false)
>  AC_CHECK_PROGS(ICOTOOL, icotool, false)
>  AC_CHECK_PROGS(MSGFMT, msgfmt, false)
>
> +dnl Check the msgfmt version
> +if test "$MSGFMT" = "msgfmt"
> +then
> - AC_MSG_CHECKING([for recent enough msgfmt/gettext (at least 0.15)])
> - msgfmt_version=`msgfmt --version | head -n1`
> - if test "x$msgfmt_version" != "x"
> - then
> - msgfmt_version_major=`expr "$msgfmt_version" : '.* ([[0-9]]*).[[0-9]]*'`
> - msgfmt_version_minor=`expr "$msgfmt_version" : '.* [[0-9]]*.([[0-9]]*)'`
> - if test "$msgfmt_version_major" -eq 0 -a "$msgfmt_version_minor" -lt 15
> - then
> -
>  MSGFMT=false
> -
>  AC_MSG_RESULT([no ($msgfmt_version_major.$msgfmt_version_minor)])
> - else
> -
>  AC_MSG_RESULT([yes ($msgfmt_version_major.$msgfmt_version_minor)])
> - fi
> - fi
>
> +fi

It would be better to test that the features that we need work.

[PATCH] configure: Check if version of msgfmt/gettext is recent enough (at least 0.15).

[Christian Costa]

Le 02/03/2012 18:02, Alexandre Julliard a écrit :
> Christian Costa  writes:
> > @@ -284,6 +284,25 @@ AC_CHECK_PROGS(CONVERT, convert, false)
> >   AC_CHECK_PROGS(ICOTOOL, icotool, false)
> >   AC_CHECK_PROGS(MSGFMT, msgfmt, false)
> >
> > +dnl Check the msgfmt version
> > +if test "$MSGFMT" = "msgfmt"
> > +then
> > - AC_MSG_CHECKING([for recent enough msgfmt/gettext (at least 0.15)])
> > - msgfmt_version=`msgfmt --version | head -n1`
> > - if test "x$msgfmt_version" != "x"
> > - then
> > - msgfmt_version_major=`expr "$msgfmt_version" : '.* ([[0-9]]*).[[0-9]]*'`
> > - msgfmt_version_minor=`expr "$msgfmt_version" : '.* [[0-9]]*.([[0-9]]*)'`
> > - if test "$msgfmt_version_major" -eq 0 -a "$msgfmt_version_minor" -lt 15
> > - then
> > -
> >  MSGFMT=false
> > -
> >  AC_MSG_RESULT([no ($msgfmt_version_major.$msgfmt_version_minor)])
> > - else
> > -
> >  AC_MSG_RESULT([yes ($msgfmt_version_major.$msgfmt_version_minor)])
> > - fi
> > - fi
> >
> > +fi
>
> It would be better to test that the features that we need work.

Do you mean checking if msgctxt keyword is supported ?