DOS stuff pretty much broken [Re: wine/ dlls/kernel/kernel_main.c dlls/kernel/wp ...]

[Andreas Mohr]

On Tue, Dec 04, 2001 at 02:54:50PM -0500, Alexandre Julliard wrote:
> ChangeSet ID:	1007495689308334133587778
> CVSROOT:	/opt/cvs-commit
> Module name:	wine
> Changes by:	julliard@wine2.	01/12/04 14:54:50
>
> Modified files:
>    dlls/kernel    : kernel_main.c wprocs.spec 
>    dlls/ntdll     : Makefile.in ntdll.spec 
>    dlls/winedos   : Makefile.in dosvm.c int09.c module.c 
>                     winedos.spec 
>    graphics       : dispdib.c 
>    include        : callback.h miscemu.h 
>    miscemu        : main.c 
>    msdos          : Makefile.in dosmem.c dpmi.c int20.c int21.c 
>                     int2f.c interrupts.c ioports.c 
> Added files:
>    dlls/winedos   : devices.c dosaspi.c dosexe.h int10.c int16.c 
>                     int17.c int19.c int20.c int21.c int29.c int31.c 
>                     int33.c ioports.c vga.c vga.h xms.c 
> Removed files:
>    include        : dosexe.h vga.h 
>    msdos          : devices.c dosaspi.c int10.c int16.c int17.c 
>                     int19.c int29.c int33.c vga.c xms.c
>
> Log message:
>    Moved most of the real-mode stuff to dlls/winedos.
>
> Patch: http://cvs.winehq.com/patch.py?id=1007495689308334133587778

This one probably breaks a whole heap of older Win3.x apps.
When I started the Win98 setup.exe for fun, it choked on int 0x21
"list of lists" (DOS_LOLSeg not initialized).
Trouble is that we initialize DOS variables in case of DOS programs *only*.
This is rather fatal IMHO, especially in the case of List Of Lists, which
is a pretty important structure with lots of information that some Win 3.x
programs might rely on.
Thus DOS stuff should be reorganized somehow.

Any suggestions ?

IMHO probably winedos should get loaded as soon as DOS3Call() gets called even
once.

[Alexandre Julliard]

Andreas Mohr  writes:
> This is rather fatal IMHO, especially in the case of List Of Lists, which
> is a pretty important structure with lots of information that some Win 3.x
> programs might rely on.
> Thus DOS stuff should be reorganized somehow.
>
> Any suggestions ?
>
> IMHO probably winedos should get loaded as soon as DOS3Call() gets called even
> once.

That's probably a bit too much, but yes DOS calls that somehow need
data structures created in winedos should load it. And in fact more of
the DOS structures stuff should be moved there, so that well-behaved
applications don't incur the cost of setting it up.