Re: [PATCH 1/2] winex11: fix gl drawable type

[Alexandre Julliard]

Miklós Máté  writes:
> @@ -1344,7 +1344,7 @@ static BOOL create_gl_drawable( HWND hwnd, struct gl_drawable *gl )
>      if (data)
>      {
> -
>        gl->type = DC_GL_WINDOW;
> -
>        gl->type = DC_GL_CHILD_WIN;

This can't possibly work, top-level windows and child windows have to be
treated differently.

[PATCH 1/2] winex11: fix gl drawable type

[Miklós Máté]

On 06/20/2016 09:42 AM, Alexandre Julliard wrote:
> Miklós Máté  writes:
> > @@ -1344,7 +1344,7 @@ static BOOL create_gl_drawable( HWND hwnd, struct gl_drawable *gl )
> >       if (data)
> >       {
> > -
> >        gl->type = DC_GL_WINDOW;
> > -
> >        gl->type = DC_GL_CHILD_WIN;
>
> This can't possibly work, top-level windows and child windows have to be
> treated differently.

I admit, I don't fully understand the top-level - child (whole - 
client?) window thing.

I just sent a new patch that replaces this series, I hope it's closer to 
the optimal solution.

MM

[PATCH 1/2] winex11: fix gl drawable type

[Alexandre Julliard]

Miklós Máté  writes:
> On 06/20/2016 09:42 AM, Alexandre Julliard wrote:
> > Miklós Máté  writes:
> > > @@ -1344,7 +1344,7 @@ static BOOL create_gl_drawable( HWND hwnd, struct gl_drawable *gl )
> > >             if (data)
> > >           {
> > > -
> > >        gl->type = DC_GL_WINDOW;
> > > -
> > >        gl->type = DC_GL_CHILD_WIN;
> >
> > This can't possibly work, top-level windows and child windows have to be
> > treated differently.
>
> I admit, I don't fully understand the top-level - child (whole - 
> client?) window thing.
>
> I just sent a new patch that replaces this series, I hope it's closer
> to the optimal solution.

Yes, that one looks reasonable, thanks.