Re: [PATCH] Implement GetShellSecurityDescriptor and test for it

[Francois Gouget]

On Mon, 6 Nov 2006, Andrey Turkin wrote:
[...]
> The patch also adds 2 structures definitions to include/shlwapi.h. 
> According to MSDN, one of these structures should be placed into 
> include/shlobj.h,

The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID, 
SHELL_USER_PERMISSION or GetShellSecurityDescriptor(). So they should be 
defined in a private shlwapi header, not in include/shlobj.h or 
include/shlwapi.h.
> but I think it is bad idea to include shlobj.h from 
> shlwapi.h (at least at the moment).

It would certainly be a bad idea since the PSDK's shlwapi.h header does 
not include shlobj.h.

[PATCH] Implement GetShellSecurityDescriptor and test for it

[Andrey Turkin]

Francois Gouget wrote:
> On Mon, 6 Nov 2006, Andrey Turkin wrote:
> [...]
> > The patch also adds 2 structures definitions to include/shlwapi.h. 
> > According to MSDN, one of these structures should be placed into 
> > include/shlobj.h,
>
> The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID, 
> SHELL_USER_PERMISSION or GetShellSecurityDescriptor(). So they should be 
> defined in a private shlwapi header, not in include/shlobj.h or 
> include/shlwapi.h.

Which PSDK version do you have?
> > but I think it is bad idea to include shlobj.h from 
> > shlwapi.h (at least at the moment).
>
> It would certainly be a bad idea since the PSDK's shlwapi.h header does 
> not include shlobj.h.

[PATCH] Implement GetShellSecurityDescriptor and test for it

[Francois Gouget]

On Mon, 6 Nov 2006, Andrey Turkin wrote:
[...]
> > The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID,
> > SHELL_USER_PERMISSION or GetShellSecurityDescriptor(). So they should be
> > defined in a private shlwapi header, not in include/shlobj.h or
> > include/shlwapi.h.
>
> Which PSDK version do you have?

It seems they all agree on this. For instance Windows 2003 SP2 20060315 
PSDK.

[PATCH] Implement GetShellSecurityDescriptor and test for it

[Andrey Turkin]

Please ignore this patch. I'll resubmit corrected version.

Francois, thanks!

Francois Gouget wrote:
> On Mon, 6 Nov 2006, Andrey Turkin wrote:
> [...]
> > > The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID,
> > > SHELL_USER_PERMISSION or GetShellSecurityDescriptor(). So they should be
> > > defined in a private shlwapi header, not in include/shlobj.h or
> > > include/shlwapi.h.
> >
> > Which PSDK version do you have?
>
> It seems they all agree on this. For instance Windows 2003 SP2 20060315 
> PSDK.