Re: mshtml: avoid shadowing a parameter (2/2)

[Jacek Caban]

Hi Austin,

On 3/9/11 10:07 AM, Austin English wrote:
> diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c
> index d0d378f..9948a02 100644
> --- a/dlls/mshtml/htmlwindow.c
> +++ b/dlls/mshtml/htmlwindow.c
> @@ -2141,22 +2141,22 @@ static HRESULT HTMLWindow_invoke(DispatchEx *dispex, DISPID id, LCID lcid, WORD
>   switch(prop->type) {
>   case GLOBAL_SCRIPTVAR: {
> -
>    IDispatchEx *dispex;
> -
>    IDispatchEx *dpex;

How about renaming argument name to 'iface'? It's not really an 
interface, but its purpose in this context is like iface arguments in 
regular COM objects.

Jacek

mshtml: avoid shadowing a parameter (2/2)

[Austin English]

On Wed, Mar 9, 2011 at 06:30, Jacek Caban  wrote:
> Hi Austin,
>
> On 3/9/11 10:07 AM, Austin English wrote:
> > diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c
> > index d0d378f..9948a02 100644
> > --- a/dlls/mshtml/htmlwindow.c
> > +++ b/dlls/mshtml/htmlwindow.c
> > @@ -2141,22 +2141,22 @@ static HRESULT HTMLWindow_invoke(DispatchEx
> > *dispex, DISPID id, LCID lcid, WORD
> >
> > switch(prop->type) {
> >      case GLOBAL_SCRIPTVAR: {
> > - IDispatchEx *dispex;
> > - IDispatchEx *dpex;
>
> How about renaming argument name to 'iface'? It's not really an interface,
> but its purpose in this context is like iface arguments in regular COM
> objects.

Sure, resent. Thanks for reviewing!