Advantages of this format: - all table elements have constant size, that makes iterating table easier - allow report lookup by report ID in O(1) time - doesn't sort reports, it makes it possible to preserve original order of elements making output of functions more similar to native - preparsed data is created from collection, this will allow to add support for multiple top-most collections
Signed-off-by: Piotr Caban piotr@codeweavers.com --- dlls/hid/hidp.c | 239 +++++++----------- dlls/hid/parse.h | 39 ++- dlls/hidclass.sys/descriptor.c | 437 +++++++++++---------------------- dlls/hidclass.sys/device.c | 4 +- dlls/hidclass.sys/parse.h | 25 +- 5 files changed, 250 insertions(+), 494 deletions(-)
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=52136
Your paranoid android.
=== debian9 (build log) ===
error: patch failed: dlls/hidclass.sys/descriptor.c:736 Task: Patch failed to apply
=== debian9 (build log) ===
error: patch failed: dlls/hidclass.sys/descriptor.c:736 Task: Patch failed to apply
Signed-off-by: Aric Stewart aric@codeweavers.com
On 5/13/19 5:33 AM, Piotr Caban wrote:
Advantages of this format: - all table elements have constant size, that makes iterating table easier - allow report lookup by report ID in O(1) time - doesn't sort reports, it makes it possible to preserve original order of elements making output of functions more similar to native - preparsed data is created from collection, this will allow to add support for multiple top-most collections
Signed-off-by: Piotr Caban piotr@codeweavers.com
dlls/hid/hidp.c | 239 +++++++----------- dlls/hid/parse.h | 39 ++- dlls/hidclass.sys/descriptor.c | 437 +++++++++++---------------------- dlls/hidclass.sys/device.c | 4 +- dlls/hidclass.sys/parse.h | 25 +- 5 files changed, 250 insertions(+), 494 deletions(-)
-
Aric Stewart -
Marvin -
Piotr Caban