Re: [PATCH 1/5] d3drm: Add stubs for IDirect3DRMFrame interface. (v3)

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-06-15 um 10:35 schrieb Aaryaman Vasishta:
> +static HRESULT WINAPI d3drm_frame1_GetVisuals(IDirect3DRMFrame *iface, IDirect3DRMVisualArray **visuals)
> +{
> - struct d3drm_frame *frame = impl_from_IDirect3DRMFrame(iface);
> - struct d3drm_visual_array *array;
> -
> - TRACE("iface %p, visuals %p.\n", iface, visuals);
> -
> - if (!visuals)
> -
>    return D3DRMERR_BADVALUE;
> -
> - if (!(array = d3drm_visual_array_create(frame->nb_visuals, frame->visuals)))
> -
>    return E_OUTOFMEMORY;
> -
> - *visuals = &array->IDirect3DRMVisualArray_iface;
> -
> - return D3DRM_OK;
>
> +}

This is a reimplementation instead of a thunk. Intentional? The same applies to d3drm_frame1_GetTransform.
> +static HRESULT WINAPI d3drm_frame1_GetSceneBackgroundDepth(IDirect3DRMFrame *iface,
> -
>                                                       IDirectDrawSurface **surface)

The indentation here is different.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXYcT1AAoJEN0/YqbEcdMwUHcQAIAfKv2BAfasnwRACZsGBcK9
VAftr2zuIgmlMKtQaplsZuv2ZqcyUnydOgzuXQusFfBldeKeD1ukycLx/sONpuZI
ggt7AbXcslw9T0wlprTnfl+1Pna/CSbRQWhVAjeB9dCCWblBslipsj9SLr3hTOwH
ppQYvk+BtoXb7A+tvVI2ch/Q8HhwWh/Q9SvVg6tUV7gQLrPG0sj4NEjG50I7VN0c
PjLgZHlT7JzVDxlGoefhTPXZdL+1muSIIuxVXho+oNx6qFqiyC0+7xxlJEVR2Eyo
VBzdczdYd0UcLRb0GOqyJpRcGTpYE06zahKeDyODIXeorFB0NlYFqSTD2H32RVNU
M2a+xKgFLqm4zu+cabfRIvFk9wGkIRykwfm8KUY4LyZCZmlQZ21nPCAIsuolRqV6
DrmQAParbMg/fAb6L9/uB0rb/CBPGIhm3mtv00TewBG8VG16uV4vLbvtoiIJJtD4
Z6iY6x948K+jjVVkhGDRfdEJn+nQRDTKIkgsRKic9S5x/nOEyfreVutjq4vULnGk
l5hRAzyzOxjP/JTMHhvYtHYbLtqjgXPi3pwhjrfGMWLKAmeRPk3A2FdsUl9A1I3I
INR8LmGAo3P7a1GZ21loc5A2iftn29vcAB0mDzcotczOEsinfx7Sc4oF5fIUDZla
miBufY1gPaDENTTiRcz5
=hvk0
-----END PGP SIGNATURE-----