Re: rstrtmgr: add RmShutdown stub (resend)

[Sebastian Lackner]

On 25.01.2017 06:28, Austin English wrote:
> CC: Sebastian Lackner
>
> Supersedes https://source.winehq.org/patches/data/128639
>
> Fixes https://bugs.winehq.org/show_bug.cgi?id=42093
>
> Staged, https://github.com/wine-compholio/wine-staging/commit/b013afa66065427110c02f...
>
> -- -Austin GPG: 14FB D7EA A041 937B
>
> 0001-rstrtmgr-add-RmShutdown-stub-resend.patch
>
> From fab99f2f9e398978461af053b38aa9b06b7bdc1d Mon Sep 17 00:00:00 2001
> From: Austin English 
> Date: Wed, 28 Dec 2016 02:18:13 -0600
> Subject: [PATCH] rstrtmgr: add RmShutdown stub (resend)
> Signed-off-by: Austin English
>
> dlls/rstrtmgr/main.c        | 9 +++++++++
>  dlls/rstrtmgr/rstrtmgr.spec | 2 +-
>  include/restartmanager.h    | 3 +++
>  3 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/rstrtmgr/main.c b/dlls/rstrtmgr/main.c
> index 2d45639..5c9a8dc 100644
> --- a/dlls/rstrtmgr/main.c
> +++ b/dlls/rstrtmgr/main.c
> @@ -100,3 +100,12 @@ DWORD WINAPI RmEndSession(DWORD handle)
>      FIXME("%u stub!\n", handle);
>      return ERROR_CALL_NOT_IMPLEMENTED;
>  }
> -
>
> +/***********************************************************************
> -
> - RmShutdown (rstrtmgr.@)
> - */
>
> +DWORD WINAPI RmShutdown(DWORD handle, ULONG flags, RM_WRITE_STATUS_CALLBACK status)
> +{
> - FIXME("%u, 0x%08x, %p stub!\n", handle, flags, status);
> - return ERROR_CALL_NOT_IMPLEMENTED;
>
> +}
> diff --git a/dlls/rstrtmgr/rstrtmgr.spec b/dlls/rstrtmgr/rstrtmgr.spec
> index 0e1ba79..6c6a9c9 100644
> --- a/dlls/rstrtmgr/rstrtmgr.spec
> +++ b/dlls/rstrtmgr/rstrtmgr.spec
> @@ -8,5 +8,5 @@
>  @ stub RmRemoveFilter
>  @ stub RmReserveHeap
>  @ stdcall RmRestart(long long ptr)
> -@ stub RmShutdown
> +@ stdcall RmShutdown(long long ptr)
>  @ stdcall RmStartSession(ptr long ptr)
> diff --git a/include/restartmanager.h b/include/restartmanager.h
> index 27c1a92..51867a3 100644
> --- a/include/restartmanager.h
> +++ b/include/restartmanager.h
> @@ -64,6 +64,9 @@ typedef struct {
>      BOOL bRestartable;
>  } RM_PROCESS_INFO, *PRM_PROCESS_INFO;
> -
>
> +typedef void *RM_WRITE_STATUS_CALLBACK(UINT);

The calling convention is missing here, please see the staged version how it should look like.
> -
>
> #ifdef __cplusplus
>  }
>  #endif
> -- 2.10.2