Re: [Fwd: Re: Extending File Dialog to include unix file paths]

[Michael Lin]

Hi Alexandre,

I haven't got a reply from you on this issue yet.
Please let me know what you think of the patch.

Thanks,
Michael

Michael Lin wrote:
> Hi Alexandre,
>
> I have made the changes as you suggested to put all the entry point in 
> one single library.
>
> Basically, I have created a new library called wineunixfs.
> It currently contain modified version of filedlg.c and 
> filedlgbrowser.* and all their dependent files from commdlg.
>
> I have attached the diff file for the rest of the changes that's on 
> the core libraries.
> I didn't attach the files in wineunixfs as you seems ok with 
> duplicating code there and modify it there.
>
> Most of the changes are contained within shell32 libraries to make it 
> aware of whether it is in unix or dos path mode.
> There is only one exported function been added and that is 
> SHUnixFSGetDesktopFolder() in shell32.
>
> Could you please take a look at the patch and let me know if this is 
> "clean" and acceptable.
>
> Thanks,
> Michael

[Fwd: Re: Extending File Dialog to include unix file paths]

[Alexandre Julliard]

Michael Lin  writes:
> Hi Alexandre,
>
> I haven't got a reply from you on this issue yet.
> Please let me know what you think of the patch.

I think it's still too intrusive, and it's still adding entry points
where it shouldn't. Anyway, I would suggest to not try to get stuff
into CVS at this point, but write a prototype and make a few apps work
properly with it; then we can talk about how to integrate it.