Re: [1/2] reg: Implement basic 'reg add'. - wine-devel

20 Mar 2008

      "Andrew Riedi" andrewriedi@gmail.com wrote:
...
+int reg_lstrncmpiW(const WCHAR *s1, const WCHAR *s2, size_t n)
CompareString is better.
...

const WCHAR hkcrW[] = {'h','k','c','r',0};
const WCHAR hkcuW[] = {'h','k','c','u',0};
const WCHAR hklmW[] = {'h','k','l','m',0};
const WCHAR hkuW[] = {'h','k','u',0};
const WCHAR hkccW[] = {'h','k','c','c',0};
const WCHAR hkddW[] = {'h','k','d','d',0};

You should make all const strings static.
...

/* TODO: Remote registry editing. */
if (key_name[0] == '\' && key_name[1] == '\')
{
   fprintf(stderr, "Remote registry editing not implemented.\n");

   return 1;

}

Please use normal WINE_TRACE, WINE_ERR, etc instead of fprintf.
-- 
Dmitry.