Re: [PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

[Paul Vriens]

On 02/26/2010 10:19 AM, Reece Dunn wrote:
> Hi,
>
> This fixes the test failures in msxml3:domdoc when IE7 or later is installed.
> - Reece

Hi Reece,

It's definitely not IE7+ only. All W2K3 boxes for the latest winetest:

http://test.winehq.org/data/062628ad8020e09063fcdf6302e86f17321e2ea8/index_2...

have IE6 installed and only some fail.

The change seems to be as of XP-SP3+, W2K3-SP2+ and Vista/W2K8/Win7.

An interesting thing is to find out why, although that would not be part 
of this patch. Nikolay and I have been discussing this the last week and 
we both didn't figure out the implementation logic (yet).

[PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

[Reece Dunn]

On 26 February 2010 09:31, Paul Vriens  wrote:
> On 02/26/2010 10:19 AM, Reece Dunn wrote:
> > Hi,
> >
> > This fixes the test failures in msxml3:domdoc when IE7 or later is
> > installed.
> > - Reece
>
> Hi Reece,
>
> It's definitely not IE7+ only. All W2K3 boxes for the latest winetest:
>
> http://test.winehq.org/data/062628ad8020e09063fcdf6302e86f17321e2ea8/index_2...
>
> have IE6 installed and only some fail.
>
> The change seems to be as of XP-SP3+, W2K3-SP2+ and Vista/W2K8/Win7.
>
> An interesting thing is to find out why, although that would not be part of
> this patch. Nikolay and I have been discussing this the last week and we
> both didn't figure out the implementation logic (yet).

Is it to do with the internet security settings in the Windows control
panel (or ActiveX run permissions in the same area -- as MSDN on
IObjectSafety mentions ATL which implements ActiveX/COM components)?

- Reece

[PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

[Paul Vriens]

On 02/26/2010 10:37 AM, Reece Dunn wrote:
> On 26 February 2010 09:31, Paul Vriens  wrote:
> > On 02/26/2010 10:19 AM, Reece Dunn wrote:
> > > Hi,
> > >
> > > This fixes the test failures in msxml3:domdoc when IE7 or later is
> > > installed.
> > > - Reece
> >
> > Hi Reece,
> >
> > It's definitely not IE7+ only. All W2K3 boxes for the latest winetest:
> >
> > http://test.winehq.org/data/062628ad8020e09063fcdf6302e86f17321e2ea8/index_2...
> >
> > have IE6 installed and only some fail.
> >
> > The change seems to be as of XP-SP3+, W2K3-SP2+ and Vista/W2K8/Win7.
> >
> > An interesting thing is to find out why, although that would not be part of
> > this patch. Nikolay and I have been discussing this the last week and we
> > both didn't figure out the implementation logic (yet).
>
> Is it to do with the internet security settings in the Windows control
> panel (or ActiveX run permissions in the same area -- as MSDN on
> IObjectSafety mentions ATL which implements ActiveX/COM components)?

Could be worthwhile checking. The weekend is coming up so maybe I will 
have some time to check this out. Be my guest to check this out yourself 
btw ;)

[PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

[Reece Dunn]

On 26 February 2010 09:54, Paul Vriens  wrote:
> On 02/26/2010 10:37 AM, Reece Dunn wrote:
> > On 26 February 2010 09:31, Paul Vriens  wrote:
> > > On 02/26/2010 10:19 AM, Reece Dunn wrote:
> > > > Hi,
> > > >
> > > > This fixes the test failures in msxml3:domdoc when IE7 or later is
> > > > installed.
> > > > - Reece
> > >
> > > Hi Reece,
> > >
> > > It's definitely not IE7+ only. All W2K3 boxes for the latest winetest:
> > >
> > > http://test.winehq.org/data/062628ad8020e09063fcdf6302e86f17321e2ea8/index_2...
> > >
> > > have IE6 installed and only some fail.
> > >
> > > The change seems to be as of XP-SP3+, W2K3-SP2+ and Vista/W2K8/Win7.
> > >
> > > An interesting thing is to find out why, although that would not be part
> > > of
> > > this patch. Nikolay and I have been discussing this the last week and we
> > > both didn't figure out the implementation logic (yet).
> >
> > Is it to do with the internet security settings in the Windows control
> > panel (or ActiveX run permissions in the same area -- as MSDN on
> > IObjectSafety mentions ATL which implements ActiveX/COM components)?
>
> Could be worthwhile checking. The weekend is coming up so maybe I will have
> some time to check this out. Be my guest to check this out yourself btw ;)

fail?	Windows		MSXML		MSXML Service Pack
==========================================================
NO	Win2003 SP1	8.70.1104.0	3.0 SP7
YES	Win2003 SP2	8.80.1185.0	3.0 Post SP8
NO	WinXP SP2	8.50.2162.0	3.0 SP5
YES	WinXP SP3	8.100.1048.0	3.0 SP10 (not in the support list)
YES	WinXP + IE8	8.100.1048.0	3.0 SP10 (not in the support list)

msxml3 SP versions taken from http://support.microsoft.com/kb/269238

So it looks like it is on msxml3 SP8+ that the change is present
(which makes more sense than my original idea).

If you want to submit the fix, go ahead. If not, I'll do it tonight.

- Reece