Re: programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Mac OS/X

[Alexandre Julliard]

Aric Stewart  writes:
> @@ -403,6 +404,13 @@ static HRESULT convert_to_native_icon(IStream *icoFile, int *indices, int numInd
>          WINE_ERR("error 0x%08X creating IWICBitmapDecoder\n", hr);
>          goto end;
>      }
> +#ifdef __APPLE__
> - hr = IWICImagingFactory_CreateBitmapScaler(factory, &scaler);
> - if (FAILED(hr))
> - {
> -
>    WINE_WARN("error 0x%08X creating IWICBitmapScaler\n", hr);
> - }
>
> +#endif

Please try to do that without adding #ifdefs in generic functions.

programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Mac OS/X

[Aric Stewart]

I can but i feel like it would be more esoteric.
Something like if numIndices is greater than 1... Would that be more preferable?

-aric

On 10/16/12 1:39 PM, Alexandre Julliard wrote:
> Aric Stewart  writes:
> > @@ -403,6 +404,13 @@ static HRESULT convert_to_native_icon(IStream *icoFile, int *indices, int numInd
> >           WINE_ERR("error 0x%08X creating IWICBitmapDecoder\n", hr);
> >           goto end;
> >       }
> > +#ifdef __APPLE__
> > - hr = IWICImagingFactory_CreateBitmapScaler(factory, &scaler);
> > - if (FAILED(hr))
> > - {
> > -
> >    WINE_WARN("error 0x%08X creating IWICBitmapScaler\n", hr);
> > - }
> >
> > +#endif
>
> Please try to do that without adding #ifdefs in generic functions.

programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Mac OS/X

[Alexandre Julliard]

Aric Stewart  writes:
> I can but i feel like it would be more esoteric.
> Something like if numIndices is greater than 1... Would that be more preferable?

No, but there's no reason that icon scaling would be Mac-specific, it
just needs a general mechanism for specifying destination size or
something like that.