Re: version: Constify a formal parameter of VerQueryValue{A|W}()

[Felix Nawothnig]

Andrew Talbot wrote:
> -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock,
> +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock,

This is wrong - in the PSDK headers it's LPSTR (the first parameter 
should be const though).

Felix

version: Constify a formal parameter of VerQueryValue{A|W}()

[Andrew Talbot]

Felix Nawothnig wrote:
> Andrew Talbot wrote:
> > -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock,
> > +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock,
>
> This is wrong - in the PSDK headers it's LPSTR (the first parameter
> should be const though).
>
> Felix

I've seen this function represented with the first two parameters
constified. Is anyone aware of a more const-correct version in the field
than the one Felix mentions?

-- Andy.

version: Constify a formal parameter of VerQueryValue{A|W}()

[Felix Nawothnig]

Andrew Talbot wrote:
> I've seen this function represented with the first two parameters
> constified. Is anyone aware of a more const-correct version in the field
> than the one Felix mentions?

Sorry about that, seems they changed the declaration in the new headers 
- I misinterpreted your comment about the first parameter.

What's the problem with it anyway? Just keep adding "const" to internal 
functions until the warnings disappear. :)

Felix